Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
28cd3c4e01 target/riscv: Remaining rvc insn reuse 32 bit translators
db8685ead5 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
cf234b4e98 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
c78ee6eb34 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
917f362553 target/riscv: Convert @cs_2 insns to share translation functions
7d5869fe83 target/riscv: Remove decode_RV32_64G()
76f5f035f1 target/riscv: Remove gen_system()
375b4b15f5 target/riscv: Rename trans_arith to gen_arith
41e910df32 target/riscv: Remove manual decoding of RV32/64M insn
ebc811a04f target/riscv: Remove shift and slt insn manual decoding
a58503eb20 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
7b2d9c4ba9 target/riscv: Move gen_arith_imm() decoding into trans_* functions
5c4ceeb7eb target/riscv: Remove manual decoding from gen_store()
6f01cea928 target/riscv: Remove manual decoding from gen_load()
1b464700f0 target/riscv: Remove manual decoding from gen_branch()
37c351dc1f target/riscv: Remove gen_jalr()
44148247a4 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
9860af10ce target/riscv: Convert quadrant 1 of RVXC insns to decodetree
98a034a5cd target/riscv: Convert quadrant 0 of RVXC insns to decodetree
d85452cbc3 target/riscv: Convert RV priv insns to decodetree
597f79d06e target/riscv: Convert RV64D insns to decodetree
3b4f3b8cde target/riscv: Convert RV32D insns to decodetree
a9cc520dfd target/riscv: Convert RV64F insns to decodetree
d3fcf4468a target/riscv: Convert RV32F insns to decodetree
6d4401451b target/riscv: Convert RV64A insns to decodetree
cc260b2d08 target/riscv: Convert RV32A insns to decodetree
606da2d9b8 target/riscv: Convert RVXM insns to decodetree
5238cdf1ec target/riscv: Convert RVXI csr insns to decodetree
e3063e377e target/riscv: Convert RVXI fence insns to decodetree
638674dbc4 target/riscv: Convert RVXI arithmetic insns to decodetree
2fae598d65 target/riscv: Convert RV64I load/store insns to decodetree
44b8014fde target/riscv: Convert RV32I load/store insns to decodetree
359c51b5f4 target/riscv: Convert RVXI branch insns to decodetree
12375de48a target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 12375de48a1c (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 359c51b5f4db (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 44b8014fde1d (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 2fae598d650f (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 638674dbc45b (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit e3063e377e09 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 5238cdf1ec11 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 606da2d9b8b4 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit cc260b2d0894 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 6d4401451b33 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit d3fcf4468a89 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit a9cc520dfd60 (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 3b4f3b8cde6a (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 597f79d06e01 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit d85452cbc30f (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 98a034a5cdbd (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 9860af10cedc (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit 44148247a47b (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 37c351dc1f86 (target/riscv: Remove gen_jalr())
20/34 Checking commit 1b464700f066 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 6f01cea92849 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 5c4ceeb7eb44 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 7b2d9c4ba9f6 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit a58503eb20e9 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit ebc811a04fe1 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit 41e910df3275 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 375b4b15f579 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 76f5f035f145 (target/riscv: Remove gen_system())
29/34 Checking commit 7d5869fe838f (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit 917f362553d0 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit c78ee6eb342e (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit cf234b4e9825 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit db8685ead54d (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 28cd3c4e01bd (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden