|
From: | Guenter Roeck |
Subject: | Re: [Qemu-riscv] [Qemu-devel] [PATCH 1/2] riscv: virt: Fix pcie memory ranges |
Date: | Tue, 20 Nov 2018 20:07:58 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Hi Alistair, On 11/20/18 4:43 PM, Alistair Francis wrote:
On Tue, Nov 20, 2018 at 3:01 PM Guenter Roeck <address@hidden> wrote:- Provide separate maps for VIRT_PCIE_MMIO (32 bit) and VIRT_PCIE_MMIO_HIGH (64 bit) - VIRT_PCIE_PIO is for IO ports, not for the physical address - VIRT_PCIE_ECAM size reduced to size needed to cover 256 ports - Use memmap[VIRT_PCIE_ECAM].size instead of memmap[VIRT_PCIE_ECAM].base to calculate the bus number range - Use qemu_fdt_setprop_sized_cells() to create reg and ranges entries - Fix parameters for gpex_pcie_init() (ECAM and MMIO addresses were swapped) Signed-off-by: Guenter Roeck <address@hidden>Hey Gunter, Thanks for the patch! This was causing me all kinds of headaches. Unfortunately I had managed to figure out the memory addresses thanks to Bin Meng's help. You can see the new tree here: https://github.com/alistair23/qemu/tree/mainline/alistair/sifive_pcie.next
Looks good. With your patch series applied on top of v3.1-rc2 and usb.mak added to the build: Building riscv:virt:defconfig:initrd ... running ....... passed Building riscv:virt:defconfig:virtio-blk:rootfs ... running ....... passed Building riscv:virt:defconfig:virtio:rootfs ... running ....... passed Building riscv:virt:defconfig:virtio-pci:rootfs ... running ....... passed Building riscv:virt:defconfig:mmc:rootfs ... running ....... passed Building riscv:virt:defconfig:nvme:rootfs ... running ................... passed Building riscv:virt:defconfig:usb-ohci:rootfs ... running ....... passed Building riscv:virt:defconfig:usb-ehci:rootfs ... running ....... passed Building riscv:virt:defconfig:usb-xhci:rootfs ... running ....... passed Building riscv:virt:defconfig:usb-uas-ehci:rootfs ... running ....... passed Building riscv:virt:defconfig:usb-uas-xhci:rootfs ... running ....... passed Building riscv:virt:defconfig:scsi[53C810]:rootfs ... running ........ passed Building riscv:virt:defconfig:scsi[53C895A]:rootfs ... running ........ passed Building riscv:virt:defconfig:scsi[MEGASAS]:rootfs ... running ....... passed Building riscv:virt:defconfig:scsi[MEGASAS2]:rootfs ... running ....... passed Building riscv:virt:defconfig:scsi[FUSION]:rootfs ... running ....... passed Building riscv:virt:defconfig:scsi[virtio]:rootfs ... running ....... passed Building riscv:virt:defconfig:scsi[virtio-pci]:rootfs ... running ....... passed Guenter
[Prev in Thread] | Current Thread | [Next in Thread] |