Re: [PATCH v5 7/8] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine

[Aditya Gupta]

On 24/03/25 13:05, Cédric Le Goater wrote:

> On 3/24/25 08:13, Aditya Gupta wrote:
> > Hi Cedric,
> >
> > <...snip...>
> >
> > When I do this, every function using Pnv10Chip* will need to be 
> > duplicated to use Pnv11Chip*.
> >
> > I will do that.
> >
> > But what do you say about changing Pnv10 chip to Pnv1x chip ? It may 
> > only be used by Pnv10 and Pnv11, not future chips. But is that 
> > unnecessary for just two versions of the chip ?
> >
> > Just tried to think of some ways to reduce duplication, or having 
> > different files such as pnv10.c, pnv11.c ? I am not sure because 
> > these might be unnecessary things too.
>
> Please open code (and duplicate) first. Then we will see how we
> can make things common. Checking the typename in the instance_init
> handleris a hack not for upstream.

Sure Cedric, will duplicate it then.


Thanks,

- Aditya Gupta


> Thanks,
>
> C.