[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 00/17] make system memory API available for common code
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 00/17] make system memory API available for common code |
Date: |
Mon, 17 Mar 2025 16:32:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Hi,
>
> On 14/3/25 19:39, Pierrick Bouvier wrote:
>> On 3/14/25 11:34, Anthony PERARD wrote:
>>> On Fri, Mar 14, 2025 at 10:33:08AM -0700, Pierrick Bouvier wrote:
>>>> Hi,
>>>>
>>>> one patch is missing review:
>>>> [PATCH v5 12/17] hw/xen: add stubs for various functions.
>>>
>>> My "Acked-by" wasn't enough? Feel free try change it to "Reviewed-by"
>>> instead.
>>>
>> Those are differents. From what I understand, Reviewed implies Acked, but
>> the opposite is not true. If it was, they would be equivalent.
>> Thanks.
>
> IIUC on QEMU Acked-by means "as a maintainer of files modified by
> this patch, I don't have objection on my area, as long as someone
> else takes the patch". It doesn't mean the patch has been reviewed.
>
> Please correct me if I'm wrong.
Documentation/process/submitting-patches.rst has some advice, but not
much. Kernel docs are more thorough, and I believe the information
there applies to QEMU reasonably well:
https://docs.kernel.org/process/5.Posting.html#patch-formatting-and-changelogs
- [PATCH v5 09/17] exec/ram_addr: remove dependency on cpu.h, (continued)
- [PATCH v5 09/17] exec/ram_addr: remove dependency on cpu.h, Pierrick Bouvier, 2025/03/14
- [PATCH v5 12/17] hw/xen: add stubs for various functions, Pierrick Bouvier, 2025/03/14
- [PATCH v5 16/17] system/memory: make compilation unit common, Pierrick Bouvier, 2025/03/14
- [PATCH v5 15/17] include/exec/memory: move devend functions to memory-internal.h, Pierrick Bouvier, 2025/03/14
- [PATCH v5 17/17] system/ioport: make compilation unit common, Pierrick Bouvier, 2025/03/14
- Re: [PATCH v5 00/17] make system memory API available for common code, Pierrick Bouvier, 2025/03/14