[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/17] exec/memory.h: make devend_memop "target defines" agnos
From: |
Pierrick Bouvier |
Subject: |
[PATCH v3 05/17] exec/memory.h: make devend_memop "target defines" agnostic |
Date: |
Tue, 11 Mar 2025 12:57:51 -0700 |
Will allow to make system/memory.c common later.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
include/exec/memory.h | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index da21e9150b5..069021ac3ff 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -3138,25 +3138,17 @@ address_space_write_cached(MemoryRegionCache *cache,
hwaddr addr,
MemTxResult address_space_set(AddressSpace *as, hwaddr addr,
uint8_t c, hwaddr len, MemTxAttrs attrs);
-#ifdef COMPILING_PER_TARGET
/* enum device_endian to MemOp. */
static inline MemOp devend_memop(enum device_endian end)
{
QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN &&
DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN);
-#if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN
- /* Swap if non-host endianness or native (target) endianness */
- return (end == DEVICE_HOST_ENDIAN) ? 0 : MO_BSWAP;
-#else
- const int non_host_endianness =
- DEVICE_LITTLE_ENDIAN ^ DEVICE_BIG_ENDIAN ^ DEVICE_HOST_ENDIAN;
-
- /* In this case, native (target) endianness needs no swap. */
- return (end == non_host_endianness) ? MO_BSWAP : 0;
-#endif
+ bool big_endian = (end == DEVICE_NATIVE_ENDIAN
+ ? target_words_bigendian()
+ : end == DEVICE_BIG_ENDIAN);
+ return big_endian ? MO_BE : MO_LE;
}
-#endif /* COMPILING_PER_TARGET */
/*
* Inhibit technologies that require discarding of pages in RAM blocks, e.g.,
--
2.39.5
- [PATCH v3 00/17] make system memory API available for common code, Pierrick Bouvier, 2025/03/11
- [PATCH v3 01/17] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian(), Pierrick Bouvier, 2025/03/11
- [PATCH v3 03/17] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 02/17] exec/tswap: implement {ld, st}.*_p as functions instead of macros, Pierrick Bouvier, 2025/03/11
- [PATCH v3 05/17] exec/memory.h: make devend_memop "target defines" agnostic,
Pierrick Bouvier <=
- [PATCH v3 07/17] exec/exec-all: remove dependency on cpu.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 04/17] exec/memory_ldst_phys: extract memory_ldst_phys declarations from cpu-all.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 08/17] exec/memory-internal: remove dependency on cpu.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 11/17] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled, Pierrick Bouvier, 2025/03/11
- [PATCH v3 09/17] exec/ram_addr: remove dependency on cpu.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 13/17] system/physmem: compilation unit is now common to all targets, Pierrick Bouvier, 2025/03/11
- [PATCH v3 15/17] include/exec/memory: move devend functions to memory-internal.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 06/17] codebase: prepare to remove cpu.h from exec/exec-all.h, Pierrick Bouvier, 2025/03/11
- [PATCH v3 16/17] system/memory: make compilation unit common, Pierrick Bouvier, 2025/03/11
- [PATCH v3 17/17] system/ioport: make compilation unit common, Pierrick Bouvier, 2025/03/11