[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnos
From: |
Pierrick Bouvier |
Subject: |
[PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic |
Date: |
Mon, 10 Mar 2025 21:08:27 -0700 |
Will allow to make system/memory.c common later.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
include/exec/memory.h | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index ff3a06e6ced..60c0fb6ccd4 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -3138,25 +3138,17 @@ address_space_write_cached(MemoryRegionCache *cache,
hwaddr addr,
MemTxResult address_space_set(AddressSpace *as, hwaddr addr,
uint8_t c, hwaddr len, MemTxAttrs attrs);
-#ifdef COMPILING_PER_TARGET
/* enum device_endian to MemOp. */
static inline MemOp devend_memop(enum device_endian end)
{
QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN &&
DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN);
-#if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN
- /* Swap if non-host endianness or native (target) endianness */
- return (end == DEVICE_HOST_ENDIAN) ? 0 : MO_BSWAP;
-#else
- const int non_host_endianness =
- DEVICE_LITTLE_ENDIAN ^ DEVICE_BIG_ENDIAN ^ DEVICE_HOST_ENDIAN;
-
- /* In this case, native (target) endianness needs no swap. */
- return (end == non_host_endianness) ? MO_BSWAP : 0;
-#endif
+ bool big_endian = (end == DEVICE_NATIVE_ENDIAN
+ ? target_words_bigendian()
+ : end == DEVICE_BIG_ENDIAN);
+ return big_endian ? MO_BE : MO_LE;
}
-#endif /* COMPILING_PER_TARGET */
/*
* Inhibit technologies that require discarding of pages in RAM blocks, e.g.,
--
2.39.5
- Re: [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop, (continued)
- [PATCH v2 11/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled, Pierrick Bouvier, 2025/03/11
- [PATCH v2 08/16] exec/memory-internal: remove dependency on cpu.h, Pierrick Bouvier, 2025/03/11
- [PATCH v2 16/16] system/ioport: make compilation unit common, Pierrick Bouvier, 2025/03/11
- [PATCH v2 15/16] system/memory: make compilation unit common, Pierrick Bouvier, 2025/03/11
- [PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic,
Pierrick Bouvier <=
- [PATCH v2 13/16] system/physmem: compilation unit is now common to all targets, Pierrick Bouvier, 2025/03/11
- [PATCH v2 12/16] hw/xen: add stubs for various functions, Pierrick Bouvier, 2025/03/11