qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] tests/functional: remove all class level fields


From: Thomas Huth
Subject: Re: [PATCH v2 3/7] tests/functional: remove all class level fields
Date: Wed, 5 Mar 2025 12:51:16 +0100
User-agent: Mozilla Thunderbird

On 28/02/2025 11.27, Daniel P. Berrangé wrote:
A number of fields are set at the class level on QemuBaseTest, even
though the exact same named field is then set at the object level
later in most cases.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  tests/functional/qemu_test/testcase.py | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/tests/functional/qemu_test/testcase.py 
b/tests/functional/qemu_test/testcase.py
index 058bf270ec..5b18416bed 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -33,12 +33,6 @@
class QemuBaseTest(unittest.TestCase): - arch = None
-
-    workdir = None
-    log = None
-    logdir = None

This seems to break the ACPI test:

https://gitlab.com/thuth/qemu/-/jobs/9316861224#L164

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]