qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 21/25] target/ppc: Fix gen_tlbsx_booke206


From: Daniel Henrique Barboza
Subject: Re: [PATCH v2 21/25] target/ppc: Fix gen_tlbsx_booke206
Date: Tue, 7 Mar 2023 18:44:50 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0



On 3/7/23 15:34, Richard Henderson wrote:
Fix incorrect read from rD.
Avoid adding 0 when rA == 0.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: C├ędric Le Goater <clg@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org
---
  target/ppc/translate.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index df324fc7ff..7ec940b7d8 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -5875,12 +5875,10 @@ static void gen_tlbsx_booke206(DisasContext *ctx)
      CHK_SV(ctx);
      if (rA(ctx->opcode)) {
          t0 = tcg_temp_new();
-        tcg_gen_mov_tl(t0, cpu_gpr[rD(ctx->opcode)]);
+        tcg_gen_add_tl(t0, cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]);
      } else {
-        t0 = tcg_const_tl(0);
+        t0 = cpu_gpr[rB(ctx->opcode)];
      }
-
-    tcg_gen_add_tl(t0, t0, cpu_gpr[rB(ctx->opcode)]);
      gen_helper_booke206_tlbsx(cpu_env, t0);
  #endif /* defined(CONFIG_USER_ONLY) */
  }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]