qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank


From: Daniel Henrique Barboza
Subject: Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select
Date: Tue, 7 Mar 2023 11:45:49 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0



On 3/7/23 10:39, David Woodhouse wrote:
On Tue, 2023-03-07 at 10:36 -0300, Daniel Henrique Barboza wrote:

Checkpatch will nag about it claiming that we need spaces between
'*'. The maintainer can fix it in-tree though.

I saw that and explicitly didn't care. 3/5 of the existing examples
within the tree look like that one — which is how the docs tell us to
do it — so I figured checkpatch could just be sad.

Regardless of how much we care about checkpatch happiness my r-b stands.

Peter said we can ignore it in this case, so yeah, checkpatch will probably
take a L.


Thanks,


Daniel


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Thanks.
        



reply via email to

[Prev in Thread] Current Thread [Next in Thread]