Re: [PATCH v2 07/10] hw/ide/piix: Require an ISABus only for user-created instances

[Michael S. Tsirkin]

On Thu, Jan 26, 2023 at 10:17:37PM +0100, Bernhard Beschow wrote:
> diff --git a/hw/isa/piix.c b/hw/isa/piix.c
> index 54a1246a9d..f9974c2a77 100644
> --- a/hw/isa/piix.c
> +++ b/hw/isa/piix.c
> @@ -345,9 +345,14 @@ static void pci_piix_realize(PCIDevice *dev, const char 
> *uhci_type,
>  
>      /* IDE */
>      qdev_prop_set_int32(DEVICE(&d->ide), "addr", dev->devfn + 1);
> +    qdev_prop_set_bit(DEVICE(&d->ide), "user-created", false);
>      if (!qdev_realize(DEVICE(&d->ide), BUS(pci_bus), errp)) {
>          return;
>      }
> +    qdev_connect_gpio_out(DEVICE(&d->ide), 0,
> +                          qdev_get_gpio_in(DEVICE(&d->pic), 14));
> +    qdev_connect_gpio_out(DEVICE(&d->ide), 1,
> +                          qdev_get_gpio_in(DEVICE(&d->pic), 15));
>  

OK, but I think we should prefix this with "x-" so we don't commit
to this as a stable API.


>      /* USB */
>      if (d->has_usb) {
> -- 
> 2.39.1