-----Original Message-----
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Sent: Thursday, 26 January 2023 12:32
To: Sriram Yagnaraman <sriram.yagnaraman@est.tech>; Jason Wang
<jasowang@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>; Michael S. Tsirkin
<mst@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>;
Alex Bennée <alex.bennee@linaro.org>; Philippe Mathieu-Daudé
<philmd@linaro.org>; Thomas Huth <thuth@redhat.com>; Wainer dos Santos
Moschetta <wainersm@redhat.com>; Beraldo Leal <bleal@redhat.com>;
Cleber Rosa <crosa@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
Paolo Bonzini <pbonzini@redhat.com>; Alexander Bulekov <alxndr@bu.edu>;
Bandan Das <bsd@redhat.com>; Stefan Hajnoczi <stefanha@redhat.com>;
Darren Kenny <darren.kenny@oracle.com>; Qiuhao Li
<Qiuhao.Li@outlook.com>; qemu-devel@nongnu.org; qemu-
ppc@nongnu.org; devel@daynix.com; Yan Vugenfirer
<yvugenfi@redhat.com>; Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH v2 00/13] Introduce igb
On 2023/01/26 18:34, Sriram Yagnaraman wrote:
-----Original Message-----
From: Sriram Yagnaraman
Sent: Tuesday, 24 January 2023 09:54
To: Akihiko Odaki <akihiko.odaki@daynix.com>; Jason Wang
<jasowang@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>; Michael S. Tsirkin
<mst@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>;
Alex
Bennée <alex.bennee@linaro.org>; Philippe Mathieu-Daudé
<philmd@linaro.org>; Thomas Huth <thuth@redhat.com>; Wainer dos
Santos Moschetta <wainersm@redhat.com>; Beraldo Leal
<bleal@redhat.com>; Cleber Rosa <crosa@redhat.com>; Laurent Vivier
<lvivier@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Alexander
Bulekov <alxndr@bu.edu>; Bandan Das <bsd@redhat.com>; Stefan
Hajnoczi
<stefanha@redhat.com>; Darren Kenny <darren.kenny@oracle.com>;
Qiuhao
Li <Qiuhao.Li@outlook.com>; qemu-devel@nongnu.org; qemu-
ppc@nongnu.org; devel@daynix.com; Yan Vugenfirer
<yvugenfi@redhat.com>; Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: RE: [PATCH v2 00/13] Introduce igb
-----Original Message-----
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Sent: Tuesday, 24 January 2023 05:54
To: Jason Wang <jasowang@redhat.com>; Sriram Yagnaraman
<sriram.yagnaraman@est.tech>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>; Michael S. Tsirkin
<mst@redhat.com>; Marcel Apfelbaum
<marcel.apfelbaum@gmail.com>;
Alex
Bennée <alex.bennee@linaro.org>; Philippe Mathieu-Daudé
<philmd@linaro.org>; Thomas Huth <thuth@redhat.com>; Wainer dos
Santos
Moschetta <wainersm@redhat.com>; Beraldo Leal <bleal@redhat.com>;
Cleber Rosa <crosa@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
Paolo Bonzini <pbonzini@redhat.com>; Alexander Bulekov
<alxndr@bu.edu>; Bandan Das <bsd@redhat.com>; Stefan Hajnoczi
<stefanha@redhat.com>; Darren Kenny <darren.kenny@oracle.com>;
Qiuhao
Li <Qiuhao.Li@outlook.com>; qemu-devel@nongnu.org; qemu-
ppc@nongnu.org; devel@daynix.com; Yan Vugenfirer
<yvugenfi@redhat.com>; Yuri Benditovich
<yuri.benditovich@daynix.com>
Subject: Re: [PATCH v2 00/13] Introduce igb
On 2023/01/16 17:01, Jason Wang wrote:
On Sat, Jan 14, 2023 at 12:10 PM Akihiko Odaki
<akihiko.odaki@daynix.com> wrote:
Based-on: <20230114035919.35251-1-akihiko.odaki@daynix.com>
([PATCH 00/19] e1000x cleanups (preliminary for IGB))
igb is a family of Intel's gigabit ethernet controllers. This
series implements
82576 emulation in particular. You can see the last patch for the
documentation.
Note that there is another effort to bring 82576 emulation. This
series was developed independently by Sriram Yagnaraman.
https://lists.gnu.org/archive/html/qemu-devel/2022-
12/msg04670.htm
l
It is possible to merge the work from Sriram Yagnaraman and to
cherry-pick useful changes from this series later.
I think there are several different ways to get the changes into
the
mainline.
I'm open to any options.
I can only do reviews for the general networking part but not the
82576 specific part. It would be better if either of the series can
get some ACKs from some ones that they are familiar with 82576,
then I can try to merge.
Thanks
I have just sent v3 to the list.
Sriram Yagnaraman, who wrote another series for 82576, is the only
person I know who is familiar with the device.
Sriram, can you take a look at v3 I have just sent?
I am at best a good interpreter of the 82576 datasheet. I will review
your changes get back here.
I have reviewed and tested your changes and it looks great to me in general.
I would like to note some features that I would like to add on top of
your patch, if you have not worked on these already :)
- PFRSTD (PF reset done)
- SRRCTL (Rx desc buf size)
- RLPML (oversized packet handling)
- MAC/VLAN anti-spoof checks
- VMOLR_STRVLAN and RPLOLR_STRVLAN (VLAN stripping for VFs)
- VMVIR (VLAN insertion for VFs)
- VF reset
- VFTE, VFRE, VFLRE
- VF stats
- Set EITR initial value
Since this is a new device and there are no existing users, is it possible to
get
the change into baseline first and fix missing features and bugs soon after?
Thanks for reviewing,
I have just submitted v4. The difference from v3 is only that igb now correctly
specifies VFs associated with queues for DMA.
RX descriptor buffer size in SRRCTL is respected since v3. I think the other
features are missing. I am not planning to implement them either, but I'm
considering to test the code with DPDK and I may add features it requires.