Re: [PATCH 2/4] ppc/pnv/pci: Remove duplicate definition of PNV_PHB5_DEVICE_ID

[Cédric Le Goater]

On 1/27/23 13:28, Frederic Barrat wrote:
> PNV_PHB5_DEVICE_ID is defined in two different headers. The definition
> in hw/pci-host/pnv_phb4.h was left out in a previous rework.
>
> Remaining definition is in hw/pci-host/pnv_phb.h.
> > Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>   include/hw/pci-host/pnv_phb4.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h
> index 17aef08f91..761525686e 100644
> --- a/include/hw/pci-host/pnv_phb4.h
> +++ b/include/hw/pci-host/pnv_phb4.h
> @@ -215,7 +215,6 @@ struct PnvPhb4PecClass {
>       OBJECT_CHECK(PnvPhb4, (obj), TYPE_PNV_PHB5)
>   
>   #define PNV_PHB5_VERSION           0x000000a500000001ull
> -#define PNV_PHB5_DEVICE_ID         0x0652
>   
>   #define TYPE_PNV_PHB5_PEC "pnv-phb5-pec"
>   #define PNV_PHB5_PEC(obj) \