Re: [PATCH v7 3/7] mac_{old,new}world: Pass MacOS VGA NDRV in card ROM instead of fw_cfg

[Mark Cave-Ayland]

On 22/01/2023 22:16, BALATON Zoltan wrote:

> > The problem you are ultimately trying to solve though is that OpenBIOS is loading 
> > the NDRV for all VGA PCI devices, so why not just fix drivers/vga.fs so that the 
> > NDRV is loaded only for the QEMU VGA device?
> >
> > > So this patch neither adds new dependency to QEMU nor repends on any change in 
> > > OpenBIOS. It just gets rid of passing files via fw_cfg.
> >
> > Unfortunately that still doesn't solve the problem of building a self-contained 
> > OpenBIOS ROM, so this patch isn't the right way forward.
>
> It does take a step to make it possible to eventually add a self contained ROM and 
> remove the vga.fs from OpenBIOS but it's not doing that fully. It just simplifies 
> QEMU and OpenBIOS vga.fs for now and making the ROM also contain the FCode will be a 
> further step but we can't get there if you don't allow to make smaller steps or don't 
> merge my patches for OpenBIOS which would allow it to run FCode ROMs. If you're 
> waiting for all this to be finished I'll give up and it will never be finished. If 
> you allow to progress in smaller steps then maybe we'll get there.

You can already add a self-contained rom using the romfile= property, so that's not 
preventing you from doing anything though? Even once OpenBIOS can read PCI option 
ROMs, the option ROM will still need to contain OpenBIOS's vga.fs as a payload, and 
it will still need to be able to inject qemu_vga.ndrv because OpenBIOS cannot have an 
external dependency upon QemuMacDrivers.


ATB,

Mark.