[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 12/19] e1000e: Improve software reset
From: |
Akihiko Odaki |
Subject: |
[PATCH 12/19] e1000e: Improve software reset |
Date: |
Sat, 14 Jan 2023 12:59:12 +0900 |
This change makes e1000e reset more things when software reset was
triggered. Some registers are exempted from software reset in the
datasheet and this change also implements the behavior accordingly.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/net/e1000e_core.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 37aec6a970..b8670662c8 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -58,6 +58,8 @@
static inline void
e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val);
+static void e1000e_reset(E1000ECore *core, bool sw);
+
static inline void
e1000e_process_ts_option(E1000ECore *core, struct e1000_tx_desc *dp)
{
@@ -1882,7 +1884,7 @@ e1000e_set_ctrl(E1000ECore *core, int index, uint32_t val)
if (val & E1000_CTRL_RST) {
trace_e1000e_core_ctrl_sw_reset();
- e1000x_reset_mac_addr(core->owner_nic, core->mac, core->permanent_mac);
+ e1000e_reset(core, true);
}
if (val & E1000_CTRL_PHY_RST) {
@@ -3488,8 +3490,7 @@ static const uint32_t e1000e_mac_reg_init[] = {
[EITR...EITR + E1000E_MSIX_VEC_NUM - 1] = E1000E_MIN_XITR,
};
-void
-e1000e_core_reset(E1000ECore *core)
+static void e1000e_reset(E1000ECore *core, bool sw)
{
int i;
@@ -3499,8 +3500,15 @@ e1000e_core_reset(E1000ECore *core)
memset(core->phy, 0, sizeof core->phy);
memcpy(core->phy, e1000e_phy_reg_init, sizeof e1000e_phy_reg_init);
- memset(core->mac, 0, sizeof core->mac);
- memcpy(core->mac, e1000e_mac_reg_init, sizeof e1000e_mac_reg_init);
+
+ for (i = 0; i < E1000E_MAC_SIZE; i++) {
+ if (sw && (i == PBA || i == PBS || i == FLA)) {
+ continue;
+ }
+
+ core->mac[i] = i < ARRAY_SIZE(e1000e_mac_reg_init) ?
+ e1000e_mac_reg_init[i] : 0;
+ }
core->rxbuf_min_shift = 1 + E1000_RING_DESC_LEN_SHIFT;
@@ -3517,6 +3525,12 @@ e1000e_core_reset(E1000ECore *core)
}
}
+void
+e1000e_core_reset(E1000ECore *core)
+{
+ e1000e_reset(core, false);
+}
+
void e1000e_core_pre_save(E1000ECore *core)
{
int i;
--
2.39.0
- [PATCH 02/19] hw/net: Add more MII definitions, (continued)
- [PATCH 02/19] hw/net: Add more MII definitions, Akihiko Odaki, 2023/01/13
- [PATCH 04/19] e1000: Use hw/net/mii.h, Akihiko Odaki, 2023/01/13
- [PATCH 03/19] fsl_etsec: Use hw/net/mii.h, Akihiko Odaki, 2023/01/13
- [PATCH 05/19] e1000: Mask registers when writing, Akihiko Odaki, 2023/01/13
- [PATCH 06/19] e1000e: Mask registers when writing, Akihiko Odaki, 2023/01/13
- [PATCH 11/19] e1000e: Remove pending interrupt flags, Akihiko Odaki, 2023/01/13
- [PATCH 07/19] e1000: Use more constant definitions, Akihiko Odaki, 2023/01/13
- [PATCH 09/19] e1000: Use memcpy to intialize registers, Akihiko Odaki, 2023/01/13
- [PATCH 08/19] e1000e: Use more constant definitions, Akihiko Odaki, 2023/01/13
- [PATCH 10/19] e1000e: Use memcpy to intialize registers, Akihiko Odaki, 2023/01/13
- [PATCH 12/19] e1000e: Improve software reset,
Akihiko Odaki <=
- [PATCH 17/19] e1000e: Remove extra pointer indirection, Akihiko Odaki, 2023/01/13
- [PATCH 14/19] e1000e: Configure ResettableClass, Akihiko Odaki, 2023/01/13
- [PATCH 18/19] tests/qtest/e1000e-test: Fix the code style, Akihiko Odaki, 2023/01/13
- [PATCH 13/19] e1000: Configure ResettableClass, Akihiko Odaki, 2023/01/13
- [PATCH 15/19] e1000e: Introduce e1000_rx_desc_union, Akihiko Odaki, 2023/01/13
- [PATCH 16/19] e1000e: Set MII_ANER_NWAY, Akihiko Odaki, 2023/01/13
- [PATCH 19/19] tests/qtest/libqos/e1000e: Remove duplicate register definitions, Akihiko Odaki, 2023/01/13