qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND v2 1/5] target/arm: Restrict 'qapi-commands-machine.h'


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH RESEND v2 1/5] target/arm: Restrict 'qapi-commands-machine.h' to system emulation
Date: Fri, 13 Jan 2023 09:14:43 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

Hi Peter,

On 20/12/22 12:11, Philippe Mathieu-Daudé wrote:
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
user-mode builds") we don't generate the "qapi-commands-machine.h"
header in a user-emulation-only build.

Move the QMP functions from helper.c (which is always compiled) to
monitor.c (which is only compiled when system-emulation is selected).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/helper.c   | 29 -----------------------------
  target/arm/m_helper.c |  1 -
  target/arm/monitor.c  | 28 ++++++++++++++++++++++++++++
  3 files changed, 28 insertions(+), 30 deletions(-)

Could you take this patch via your ARM tree?

Thanks,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]