[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/31] e1000: Split header files
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 21/31] e1000: Split header files |
|
Date: |
Thu, 12 Jan 2023 12:00:05 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 |
On 12/1/23 10:57, Akihiko Odaki wrote:
Some definitions in the header files are invalid for igb so extract
them to new header files to keep igb from referring to them.
Signed-off-by: Gal Hammer <gal.hammer@sap.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/net/e1000.c | 2 +-
hw/net/e1000_common.h | 104 +++++
hw/net/e1000_regs.h | 927 +---------------------------------------
hw/net/e1000e.c | 4 +-
hw/net/e1000e_core.c | 2 +-
hw/net/e1000x_common.c | 2 +-
hw/net/e1000x_common.h | 74 ----
hw/net/e1000x_regs.h | 940 +++++++++++++++++++++++++++++++++++++++++
8 files changed, 1051 insertions(+), 1004 deletions(-)
create mode 100644 hw/net/e1000_common.h
create mode 100644 hw/net/e1000x_regs.h
diff --git a/hw/net/e1000_common.h b/hw/net/e1000_common.h
new file mode 100644
index 0000000000..56afad3feb
--- /dev/null
+++ b/hw/net/e1000_common.h
@@ -0,0 +1,104 @@
+/*
+ * QEMU e1000(e) emulation - shared code
s/code/definitions/
+ *
+ * Copyright (c) 2008 Qumranet
+ *
+ * Based on work done by:
+ * Nir Peleg, Tutis Systems Ltd. for Qumranet Inc.
+ * Copyright (c) 2007 Dan Aloni
+ * Copyright (c) 2004 Antony T Curtis
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef HW_NET_E1000_COMMON_H
+#define HW_NET_E1000_COMMON_H
...
+#include "e1000x_common.h"
No need to include this header here. Can we restrict it to the units
requiring access to these declarations? Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
+#endif
- Re: [PATCH 01/31] e1000e: Fix the code style, (continued)
- [PATCH 02/31] hw/net: Add more MII definitions, Akihiko Odaki, 2023/01/12
- [PATCH 05/31] e1000: Mask registers when writing, Akihiko Odaki, 2023/01/12
- [PATCH 06/31] e1000e: Mask registers when writing, Akihiko Odaki, 2023/01/12
- [PATCH 07/31] e1000: Use more constant definitions, Akihiko Odaki, 2023/01/12
- [PATCH 11/31] e1000e: Remove pending interrupt flags, Akihiko Odaki, 2023/01/12
- [PATCH 19/31] hw/net/net_tx_pkt: Introduce net_tx_pkt_get_eth_hdr, Akihiko Odaki, 2023/01/12
- [PATCH 21/31] e1000: Split header files, Akihiko Odaki, 2023/01/12
- Re: [PATCH 21/31] e1000: Split header files,
Philippe Mathieu-Daudé <=
- [PATCH 22/31] igb: Copy e1000e code, Akihiko Odaki, 2023/01/12
- [PATCH 18/31] tests/qtest/libqos/e1000e: Remove duplicate register definitions, Akihiko Odaki, 2023/01/12
- [PATCH 31/31] docs/system/devices/igb: Add igb documentation, Akihiko Odaki, 2023/01/12
- [PATCH 24/31] igb: Build igb, Akihiko Odaki, 2023/01/12
- [PATCH 03/31] fsl_etsec: Use hw/net/mii.h, Akihiko Odaki, 2023/01/12
- [PATCH 25/31] igb: Transform to 82576 implementation, Akihiko Odaki, 2023/01/12
- [PATCH 09/31] e1000: Use memcpy to intialize registers, Akihiko Odaki, 2023/01/12
- [PATCH 10/31] e1000e: Use memcpy to intialize registers, Akihiko Odaki, 2023/01/12