[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 24/33] hw/isa/piix4: Remove unused inbound ISA interrupt lines
From: |
Bernhard Beschow |
Subject: |
[PATCH v6 24/33] hw/isa/piix4: Remove unused inbound ISA interrupt lines |
Date: |
Mon, 9 Jan 2023 18:23:37 +0100 |
The Malta board, which is the only user of PIIX4, doesn't connect to the
exported interrupt lines. PIIX3 doesn't expose such interrupt lines
either, so remove them for PIIX4 for simplicity and consistency.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221022150508.26830-32-shentey@gmail.com>
---
hw/isa/piix4.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index de4133f573..9edaa5de3e 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -155,12 +155,6 @@ static void piix4_request_i8259_irq(void *opaque, int irq,
int level)
qemu_set_irq(s->cpu_intr, level);
}
-static void piix4_set_i8259_irq(void *opaque, int irq, int level)
-{
- PIIX4State *s = opaque;
- qemu_set_irq(s->isa[irq], level);
-}
-
static void piix4_rcr_write(void *opaque, hwaddr addr, uint64_t val,
unsigned int len)
{
@@ -204,8 +198,6 @@ static void piix4_realize(PCIDevice *dev, Error **errp)
return;
}
- qdev_init_gpio_in_named(DEVICE(dev), piix4_set_i8259_irq,
- "isa", ISA_NUM_IRQS);
qdev_init_gpio_out_named(DEVICE(dev), &s->cpu_intr,
"intr", 1);
--
2.39.0
- Re: [PATCH v6 14/33] hw/isa/piix3: Create USB controller in host device, (continued)
- [PATCH v6 16/33] hw/isa/piix3: Create TYPE_ISA_PIC in host device, Bernhard Beschow, 2023/01/09
- [PATCH v6 18/33] hw/isa/piix3: Wire up ACPI interrupt internally, Bernhard Beschow, 2023/01/09
- [PATCH v6 13/33] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge, Bernhard Beschow, 2023/01/09
- [PATCH v6 21/33] hw/isa/piix3: Rename piix3_reset() for sharing with PIIX4, Bernhard Beschow, 2023/01/09
- [PATCH v6 20/33] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4, Bernhard Beschow, 2023/01/09
- [PATCH v6 15/33] hw/isa/piix3: Create power management controller in host device, Bernhard Beschow, 2023/01/09
- [PATCH v6 23/33] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional, Bernhard Beschow, 2023/01/09
- [PATCH v6 24/33] hw/isa/piix4: Remove unused inbound ISA interrupt lines,
Bernhard Beschow <=
- [PATCH v6 19/33] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS, Bernhard Beschow, 2023/01/09
- [PATCH v6 25/33] hw/isa/piix4: Use TYPE_ISA_PIC device, Bernhard Beschow, 2023/01/09
- [PATCH v6 22/33] hw/isa/piix3: Drop the "3" from PIIX base class, Bernhard Beschow, 2023/01/09
- [PATCH v6 27/33] hw/isa/piix4: Rename reset control operations to match PIIX3, Bernhard Beschow, 2023/01/09
- [PATCH v6 32/33] hw/isa/piix: Consolidate IRQ triggering, Bernhard Beschow, 2023/01/09
- [PATCH v6 33/33] hw/isa/piix: Share PIIX3's base class with PIIX4, Bernhard Beschow, 2023/01/09
- [PATCH v6 28/33] hw/isa/piix3: Merge hw/isa/piix4.c, Bernhard Beschow, 2023/01/09