qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] hw/ppc/sam460ex: Remove unreachable code calling pflash_


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 1/5] hw/ppc/sam460ex: Remove unreachable code calling pflash_cfi01_register()
Date: Mon, 9 Jan 2023 17:51:58 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 9/1/23 17:42, Bernhard Beschow wrote:
Am 9. Januar 2023 12:01:50 UTC schrieb "Philippe Mathieu-Daudé" 
<philmd@linaro.org>:
Since its QOM'ification in commit 368a354f02 ("pflash_cfi0x:
QOMified") the pflash_cfi01_register() function does not fail.

This call was later converted with a script to use &error_fatal,
still unable to fail. Remove the unreachable code.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/ppc/sam460ex.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

It looks like there is more: 
https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg02491.html
Doh, my short-term memory scares me :\



reply via email to

[Prev in Thread] Current Thread [Next in Thread]