RE: [PATCH v2 19/21] gdbstub: move register helpers into standalone include

[Taylor Simpson]

> -----Original Message-----
> From: Alex Bennée <alex.bennee@linaro.org>
> Sent: Thursday, January 5, 2023 10:43 AM
> To: qemu-devel@nongnu.org; alex.bennee@gmail.com
> Cc: David Hildenbrand <david@redhat.com>; Sunil Muthuswamy
> <sunilmut@microsoft.com>; Aurelien Jarno <aurelien@aurel32.net>;
> Michael Rolnik <mrolnik@gmail.com>; Aleksandar Rikalo
> <aleksandar.rikalo@syrmia.com>; Greg Kurz <groug@kaod.org>; Ilya
> Leoshkevich <iii@linux.ibm.com>; Thomas Huth <thuth@redhat.com>;
> qemu-ppc@nongnu.org; Laurent Vivier <laurent@vivier.eu>; Max Filippov
> <jcmvbkbc@gmail.com>; Yanan Wang <wangyanan55@huawei.com>; Marek
> Vasut <marex@denx.de>; Stafford Horne <shorne@gmail.com>; Peter
> Maydell <peter.maydell@linaro.org>; Daniel Henrique Barboza
> <danielhb413@gmail.com>; Palmer Dabbelt <palmer@dabbelt.com>; Alex
> Bennée <alex.bennee@linaro.org>; Taylor Simpson
> <tsimpson@quicinc.com>; Marcel Apfelbaum
> <marcel.apfelbaum@gmail.com>; Alexandre Iooss <erdnaxe@crans.org>;
> Chris Wulff <crwulff@gmail.com>; Richard Henderson
> <richard.henderson@linaro.org>; Eduardo Habkost
> <eduardo@habkost.net>; Song Gao <gaosong@loongson.cn>; Mark Cave-
> Ayland <mark.cave-ayland@ilande.co.uk>; Cédric Le Goater <clg@kaod.org>;
> Artyom Tarasenko <atar4qemu@gmail.com>; Paolo Bonzini
> <pbonzini@redhat.com>; qemu-riscv@nongnu.org; qemu-
> s390x@nongnu.org; Alistair Francis <alistair.francis@wdc.com>; Edgar E.
> Iglesias <edgar.iglesias@gmail.com>; Bastian Koppelmann
> <kbastian@mail.uni-paderborn.de>; Jiaxun Yang
> <jiaxun.yang@flygoat.com>; Philippe Mathieu-Daudé <philmd@linaro.org>;
> Bin Meng <bin.meng@windriver.com>; Mahmoud Mandour
> <ma.mandourr@gmail.com>; David Gibson <david@gibson.dropbear.id.au>;
> Yoshinori Sato <ysato@users.sourceforge.jp>; Xiaojuan Yang
> <yangxiaojuan@loongson.cn>; qemu-arm@nongnu.org
> Subject: [PATCH v2 19/21] gdbstub: move register helpers into standalone
> include
> 
> These inline helpers are all used by target specific code so move them out of
> the general header so we don't needlessly pollute the rest of the API with
> target specific stuff.
> 
> Note we have to include cpu.h in semihosting as it was relying on a side
> effect before.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c
> index d152d01bfe..46083da620 100644
> --- a/target/hexagon/gdbstub.c
> +++ b/target/hexagon/gdbstub.c
> @@ -16,7 +16,7 @@
>   */
> 
>  #include "qemu/osdep.h"
> -#include "exec/gdbstub.h"
> +#include "gdbstub/helpers.h"
>  #include "cpu.h"
>  #include "internal.h"

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>