Re: [PATCH v7 5/7] mac_newworld: Deprecate mac99 with G5 CPU

[Philippe Mathieu-Daudé]

On 4/1/23 22:59, BALATON Zoltan wrote:
> Besides resolving the confusing behaviour mentioned in previous commit
> this might also allow unifying qemu-system-ppc and qemu-system-ppc64
> in the future.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/mac_newworld.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> index 3f5d1ec097..f07c37328b 100644
> --- a/hw/ppc/mac_newworld.c
> +++ b/hw/ppc/mac_newworld.c
> @@ -165,6 +165,12 @@ static void ppc_core99_init(MachineState *machine)
>           qemu_register_reset(ppc_core99_reset, cpu);
>       }
>   
> +    if (object_property_find(OBJECT(machine), "via")) {
> +        if (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) {
> +            warn_report("mac99 with G5 CPU is deprecated, "
> +                        "use powermac7_3 instead");

"mac99 machine with G5 CPU is deprecated, prefer the powermac7_3 machine 
instead"?

> +        }
> +    }
>       /* allocate RAM */
>       if (machine->ram_size > 2 * GiB) {
>           error_report("RAM size more than 2 GiB is not supported");