|
From: | Thomas Huth |
Subject: | Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' |
Date: | Thu, 17 Nov 2022 09:24:45 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 |
On 16/11/2022 16.30, Philippe Mathieu-Daudé wrote:
On 16/11/22 16:20, Greg Kurz wrote:Hi Vaibhav, Nice to see some people are still building QEMU at IBM ;-) On Wed, 16 Nov 2022 18:47:43 +0530 Vaibhav Jain <vaibhav@linux.ibm.com> wrote:Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu' target is failing due to following build warnings: <snip>../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function]7018 | static void ppc_restore_state_to_opc(CPUState *cs, <snip>Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so thatthey are only defined if qemu is compiled with '--enable-tcg'Interestingly this config isn't covered in .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml.
Why should it be tested there? s390x is not ppc64.If you want to test this, you either have to do it with a cross compiler (in .gitlab-ci.d/crossbuilds.yml) or in .travis.yml on a ppc64 host.
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |