Re: [PATCH v5 35/49] target/ppc: Implement xxgenpcv[bhwd]m instruction

[Richard Henderson]

On 2/25/22 11:09, matheus.ferst@eldorado.org.br wrote:
>   
> +#define XXGENPCV(NAME) \
> +static bool trans_##NAME(DisasContext *ctx, arg_X_imm5 *a)  \
> +{                                                           \
> +    TCGv_ptr xt, vrb;                                       \
> +                                                            \
> +    REQUIRE_INSNS_FLAGS2(ctx, ISA310);                      \
> +    REQUIRE_VSX(ctx);                                       \
> +                                                            \
> +    if (a->imm & ~0x3) {                                    \
> +        gen_invalid(ctx);                                   \
> +        return true;                                        \
> +    }                                                       \
> +                                                            \
> +    xt = gen_vsr_ptr(a->xt);                                \
> +    vrb = gen_avr_ptr(a->vrb);                              \
> +                                                            \
> +    switch (a->imm) {                                       \
> +    case 0b00000: /* Big-Endian expansion */                \
> +        glue(gen_helper_, glue(NAME, _be_exp))(xt, vrb);    \
> +        break;                                              \
> +    case 0b00001: /* Big-Endian compression */              \
> +        glue(gen_helper_, glue(NAME, _be_comp))(xt, vrb);   \
> +        break;                                              \
> +    case 0b00010: /* Little-Endian expansion */             \
> +        glue(gen_helper_, glue(NAME, _le_exp))(xt, vrb);    \
> +        break;                                              \
> +    case 0b00011: /* Little-Endian compression */           \
> +        glue(gen_helper_, glue(NAME, _le_comp))(xt, vrb);   \
> +        break;                                              \
> +    }                                                       \
> +                                                            \
> +    tcg_temp_free_ptr(xt);                                  \
> +    tcg_temp_free_ptr(vrb);                                 \
> +                                                            \
> +    return true;                                            \
> +}
> +
> +XXGENPCV(XXGENPCVBM)
> +XXGENPCV(XXGENPCVHM)
> +XXGENPCV(XXGENPCVWM)
> +XXGENPCV(XXGENPCVDM)
> +#undef XXGENPCV

Suggestion:

typedef void (*xxgenpcv_genfn)(TCGv_ptr, TCGv_ptr);

static bool do_xxgenpcv(DisasContext *ctx, arg_X_imm5 *a,
                        xxgenpcv_genfn fn[4])
{
   ...
   fn[a->imm](xt, vrb);
   ...
}

#define XXGENPCV(NAME) \
    static bool trans_##NAME(...)
    {
        static const xxgenpcv_genfn fn[4] = {
            gen_helper_##NAME##_be_exp,
            gen_helper_##NAME##_be_comp,
            gen_helper_##NAME##_le_exp,
            gen_helper_##NAME##_le_comp,
        };
        return do_xxgenpcv(ctx, a, fn);
    }

For debugging purposes, prefer to put as little within giant macro expansion as 
possible.


r~