[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup
From: |
David Gibson |
Subject: |
Re: [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup |
Date: |
Tue, 11 Jan 2022 13:26:07 +1100 |
On Mon, Jan 10, 2022 at 03:15:43PM -0300, Fabiano Rosas wrote:
> In powerpc_excp_40x the Critical exception is now for 405 only, so we
> can remove the BookE and G2 blocks.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/ppc/excp_helper.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 1d997c4d6b..fecf4d5a4e 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -431,20 +431,8 @@ static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)
>
> switch (excp) {
> case POWERPC_EXCP_CRITICAL: /* Critical input
> */
> - switch (excp_model) {
> - case POWERPC_EXCP_40x:
> - srr0 = SPR_40x_SRR2;
> - srr1 = SPR_40x_SRR3;
> - break;
> - case POWERPC_EXCP_BOOKE:
> - srr0 = SPR_BOOKE_CSRR0;
> - srr1 = SPR_BOOKE_CSRR1;
> - break;
> - case POWERPC_EXCP_G2:
> - break;
> - default:
> - goto excp_invalid;
> - }
> + srr0 = SPR_40x_SRR2;
> + srr1 = SPR_40x_SRR3;
> break;
> case POWERPC_EXCP_MCHECK: /* Machine check exception
> */
> if (msr_me == 0) {
> @@ -698,7 +686,6 @@ static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)
> powerpc_excp_name(excp));
> break;
> default:
> - excp_invalid:
> cpu_abort(cs, "Invalid PowerPC exception %d. Aborting\n", excp);
> break;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH 1/8] target/ppc: 405: Add missing MSR bits to msr_mask, (continued)
- [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup, Fabiano Rosas, 2022/01/10
- Re: [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup,
David Gibson <=
- [PATCH 7/8] target/ppc: 405: External exception cleanup, Fabiano Rosas, 2022/01/10
- [PATCH 3/8] target/ppc: Introduce powerpc_excp_40x, Fabiano Rosas, 2022/01/10
- [PATCH 6/8] target/ppc: 405: Machine check exception cleanup, Fabiano Rosas, 2022/01/10
- [PATCH 8/8] target/ppc: 405: System call exception cleanup, Fabiano Rosas, 2022/01/10
- Re: [PATCH 0/8] target/ppc: powerpc_excp improvements [40x] (3/n), Cédric Le Goater, 2022/01/11