qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 07/13] hw/misc/auxbus: Fix MOT/classic I2C mode


From: Richard Henderson
Subject: Re: [PATCH v3 07/13] hw/misc/auxbus: Fix MOT/classic I2C mode
Date: Wed, 16 Jun 2021 11:41:31 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote:
Since its introduction in commit 6fc7f77fd2 i2c_start_transfer()
uses incorrectly the direction of the transfer (the last argument
is called 'is_recv'). Fix by inverting the argument, we now have
is_recv = !is_write.

Fixes: 6fc7f77fd2 ("introduce aux-bus")
Reported-by: BALATON Zoltan<balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  hw/misc/auxbus.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]