|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 01/13] hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h" |
Date: | Wed, 16 Jun 2021 11:38:50 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote:
lm832x_key_event() is specific go LM832x devices, not to the I2C bus API. Move it out of "i2c.h" to a new header. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/hw/i2c/i2c.h | 3 --- include/hw/input/lm832x.h | 26 ++++++++++++++++++++++++++ hw/arm/nseries.c | 1 + hw/input/lm832x.c | 1 + MAINTAINERS | 1 + 5 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 include/hw/input/lm832x.h
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
+#ifndef HW_INPUT_LM832X +#define HW_INPUT_L
You fix this error in the next patch, but better here. r~
[Prev in Thread] | Current Thread | [Next in Thread] |