Re: [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus

[Bruno Piazera Larsen]

On 15/06/2021 00:20, Richard Henderson wrote:

> On
>       6/14/21 6:41 PM, David Gibson wrote:
>       
> > I think move these to mmu-book3s-v3.h,
> >         since they're correct for both
> >         
> >         the radix and hash sides of the modern book3s mmu.
> >         
> >       
>       
>       They're also correct for all non-booke mmus, e.g. hash32 and 6xx,
>       which is why I recommended internal.h (or some new
>       mmu-internal.h).
>       
>       
>       While neither hash32 nor 6xx have HV, and thus there is no second
>       tlb bug, it would still be More Correct to use mmu_idx instead of
>       direct references to msr_pr et al.
>       
>     
    yeah, I agree that I should change the documentation. Before I send
    a new version with everything corrected, I wanna make sure if I
    should leave them in internal and use it for hash32 and 6xx MMUs, or
    do I put them in mmu-book3s-v3.h, since only radix64 has that the
    bug?
>       
>       
>       r~
>       
>

--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer