Re: [PULL 00/42] ppc-for-6.1 queue 20210603

[no-reply]

Patchew URL: 
20210603082231.601214-1-david@gibson.dropbear.id.au/">https://patchew.org/QEMU/20210603082231.601214-1-david@gibson.dropbear.id.au/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210603082231.601214-1-david@gibson.dropbear.id.au
Subject: [PULL 00/42] ppc-for-6.1 queue 20210603

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8c345b3..8e6dad2  master     -> master
 - [tag update]      patchew/20210526170432.343588-1-philmd@redhat.com -> 
patchew/20210526170432.343588-1-philmd@redhat.com
 - [tag update]      patchew/20210603001129.1319515-1-jsnow@redhat.com -> 
patchew/20210603001129.1319515-1-jsnow@redhat.com
 - [tag update]      patchew/20210603003719.1321369-1-jsnow@redhat.com -> 
patchew/20210603003719.1321369-1-jsnow@redhat.com
 * [new tag]         
patchew/20210603082231.601214-1-david@gibson.dropbear.id.au -> 
patchew/20210603082231.601214-1-david@gibson.dropbear.id.au
Switched to a new branch 'test'
b095e5a target/ppc: fix single-step exception regression
47c29de target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree
e353b8f target/ppc: Move addpcis to decodetree
0bdf1c3 target/ppc: Implement vcfuged instruction
2f32ca8 target/ppc: Implement cfuged instruction
4c6d2ea target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions
34efd90 target/ppc: Implement prefixed integer store instructions
a13f791 target/ppc: Move D/DS/X-form integer stores to decodetree
4edc2c8 target/ppc: Implement prefixed integer load instructions
0c7c48d target/ppc: Move D/DS/X-form integer loads to decodetree
9a5b0df target/ppc: Implement PNOP
ec1a4a5 target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI
328bcfb target/ppc: Add infrastructure for prefixed insns
5975efe target/ppc: Move page crossing check to ppc_tr_translate_insn
54117f1 target/ppc: Introduce macros to check isa extensions
a36fb1f target/ppc: powerpc_excp: Consolidade TLB miss code
13a26b1 target/ppc: powerpc_excp: Remove dump_syscall_vectored
9813aa4 target/ppc: powerpc_excp: Move lpes code to where it is used
f9fb77e target/ppc: overhauled and moved logic of storing fpscr
6bb7bba target/ppc: removed all mentions to PPC_DUMP_CPU
a33d7b7 target/ppc: removed GEN_OPCODE decision tree
a0a6db6 HMP: added info cpustats to removed_features.rst
4593178 hw/core/cpu: removed cpu_dump_statistics function
d97d5aa ppc/pef.c: initialize cgs->ready in kvmppc_svm_init()
974dd76 monitor: removed cpustats command
fd9ba82 target/ppc: removed mentions to DO_PPC_STATISTICS
ad63f9b target/ppc: remove ppc_cpu_dump_statistics
788299e target/ppc: updated meson.build to support disable-tcg
824f724 target/ppc: created tcg-stub.c file
7156e66 target/ppc: added ifdefs around TCG-only code
08f061f target/ppc: used ternary operator when registering MAS
d65dccf spapr: Set LPCR to current AIL mode when starting a new CPU
a356d68 spapr: Remove stale comment about power-saving LPCR bits
656de9e target/ppc: fold ppc_store_ptcr into it's only caller
7782934 spapr: nvdimm: Fix the persistent-memory root node name in device tree
12e9934 spapr: nvdimm: Forward declare and move the definitions
b0e4ac0 spapr: Fix EEH capability issue on KVM guest for PCI passthru
961e31a spapr: Don't hijack current_machine->boot_order
5f6b88e target/ppc: removed unnecessary inclusion of helper-proto.h
036ed6c target/ppc: reduce usage of fpscr_set_rounding_mode
71474f2 target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c
0a97295 target/ppc: cleaned error_report from ppc_store_sdr1

=== OUTPUT BEGIN ===
1/42 Checking commit 0a9729552899 (target/ppc: cleaned error_report from 
ppc_store_sdr1)
2/42 Checking commit 71474f2e9d8a (target/ppc: moved ppc_store_lpcr and 
ppc_store_msr to cpu.c)
3/42 Checking commit 036ed6cb6069 (target/ppc: reduce usage of 
fpscr_set_rounding_mode)
4/42 Checking commit 5f6b88e406f1 (target/ppc: removed unnecessary inclusion of 
helper-proto.h)
5/42 Checking commit 961e31a2cfe3 (spapr: Don't hijack 
current_machine->boot_order)
6/42 Checking commit b0e4ac014a5a (spapr: Fix EEH capability issue on KVM guest 
for PCI passthru)
7/42 Checking commit 12e9934ade22 (spapr: nvdimm: Forward declare and move the 
definitions)
8/42 Checking commit 778293405aba (spapr: nvdimm: Fix the persistent-memory 
root node name in device tree)
9/42 Checking commit 656de9efe247 (target/ppc: fold ppc_store_ptcr into it's 
only caller)
10/42 Checking commit a356d68a4835 (spapr: Remove stale comment about 
power-saving LPCR bits)
11/42 Checking commit d65dccfcac29 (spapr: Set LPCR to current AIL mode when 
starting a new CPU)
12/42 Checking commit 08f061ff723c (target/ppc: used ternary operator when 
registering MAS)
13/42 Checking commit 7156e661fa89 (target/ppc: added ifdefs around TCG-only 
code)
14/42 Checking commit 824f724bda7b (target/ppc: created tcg-stub.c file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 55 lines checked

Patch 14/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/42 Checking commit 788299e7f62f (target/ppc: updated meson.build to support 
disable-tcg)
16/42 Checking commit ad63f9b38e7b (target/ppc: remove ppc_cpu_dump_statistics)
17/42 Checking commit fd9ba8202b51 (target/ppc: removed mentions to 
DO_PPC_STATISTICS)
18/42 Checking commit 974dd766031f (monitor: removed cpustats command)
19/42 Checking commit d97d5aaf846e (ppc/pef.c: initialize cgs->ready in 
kvmppc_svm_init())
20/42 Checking commit 4593178b2a35 (hw/core/cpu: removed cpu_dump_statistics 
function)
21/42 Checking commit a0a6db6e970a (HMP: added info cpustats to 
removed_features.rst)
22/42 Checking commit a33d7b7c6332 (target/ppc: removed GEN_OPCODE decision 
tree)
23/42 Checking commit 6bb7bbaeaa58 (target/ppc: removed all mentions to 
PPC_DUMP_CPU)
24/42 Checking commit f9fb77e36ceb (target/ppc: overhauled and moved logic of 
storing fpscr)
25/42 Checking commit 9813aa47f6a0 (target/ppc: powerpc_excp: Move lpes code to 
where it is used)
26/42 Checking commit 13a26b109f2b (target/ppc: powerpc_excp: Remove 
dump_syscall_vectored)
27/42 Checking commit a36fb1fa990e (target/ppc: powerpc_excp: Consolidade TLB 
miss code)
28/42 Checking commit 54117f1402c1 (target/ppc: Introduce macros to check isa 
extensions)
29/42 Checking commit 5975efe65ccf (target/ppc: Move page crossing check to 
ppc_tr_translate_insn)
30/42 Checking commit 328bcfb93e72 (target/ppc: Add infrastructure for prefixed 
insns)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 30/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/42 Checking commit ec1a4a523972 (target/ppc: Move ADDI, ADDIS to decodetree, 
implement PADDI)
32/42 Checking commit 9a5b0df987b0 (target/ppc: Implement PNOP)
33/42 Checking commit 0c7c48d81c09 (target/ppc: Move D/DS/X-form integer loads 
to decodetree)
ERROR: spaces required around that '*' (ctx:WxV)
#221: FILE: target/ppc/translate.c:7581:
+    static bool trans_##NAME(DisasContext *ctx, arg_##NAME *a) \
                                                            ^

ERROR: spaces required around that '*' (ctx:WxV)
#225: FILE: target/ppc/translate.c:7585:
+    static bool trans_##NAME(DisasContext *ctx, arg_##NAME *a) \
                                                            ^

total: 2 errors, 0 warnings, 336 lines checked

Patch 33/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

34/42 Checking commit 4edc2c85be12 (target/ppc: Implement prefixed integer load 
instructions)
35/42 Checking commit a13f791fe5ff (target/ppc: Move D/DS/X-form integer stores 
to decodetree)
36/42 Checking commit 34efd908d370 (target/ppc: Implement prefixed integer 
store instructions)
37/42 Checking commit 4c6d2ea48d07 (target/ppc: Implement 
setbc/setbcr/stnbc/setnbcr instructions)
38/42 Checking commit 2f32ca8e7395 (target/ppc: Implement cfuged instruction)
39/42 Checking commit 0bdf1c355472 (target/ppc: Implement vcfuged instruction)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 79 lines checked

Patch 39/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/42 Checking commit e353b8f96b9b (target/ppc: Move addpcis to decodetree)
41/42 Checking commit 47c29dedb8d0 (target/ppc: Move cmp/cmpi/cmpl/cmpli to 
decodetree)
42/42 Checking commit b095e5ab8c43 (target/ppc: fix single-step exception 
regression)
WARNING: line over 80 characters
#33: FILE: target/ppc/translate.c:4323:
+            gen_helper_raise_exception(cpu_env, 
tcg_constant_i32(gen_prep_dbgex(ctx)));

WARNING: line over 80 characters
#42: FILE: target/ppc/translate.c:8674:
+            gen_helper_raise_exception(cpu_env, 
tcg_constant_i32(gen_prep_dbgex(ctx)));

total: 0 errors, 2 warnings, 17 lines checked

Patch 42/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210603082231.601214-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message">http://patchew.org/logs/20210603082231.601214-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com