[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbs
From: |
David Gibson |
Subject: |
Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c |
Date: |
Fri, 16 Apr 2021 13:44:29 +1000 |
On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote:
> On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote:
> > All the code related to gdb has been moved from translate_init.c.inc
> > file to the gdbstub.c file, where it makes more sense.
> >
> > This new version puts the prototypes in internal.h, to not expose
> > them unnecessarily.
> >
> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > Suggested-by: Fabiano Rosas <farosas@linux.ibm.com>
> > ---
> > target/ppc/gdbstub.c | 258 ++++++++++++++++++++++++++++++++
> > target/ppc/internal.h | 5 +
> > target/ppc/translate_init.c.inc | 254 +------------------------------
> > 3 files changed, 264 insertions(+), 253 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-6.1, thanks.
>
> > +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *pcc)
> > +{
> > +
> > + if (pcc->insns_flags & PPC_FLOAT) {
>
> Watch the extra blank lines.
Fixed in my tree.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature