[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/5] target/sh4: Drop use of gdb_get_float32() and ldfl_p()
From: |
Peter Maydell |
Subject: |
[PATCH 1/5] target/sh4: Drop use of gdb_get_float32() and ldfl_p() |
Date: |
Mon, 8 Feb 2021 11:34:24 +0000 |
We used to make a distinction between 'float64'/'float32' types and
the 'uint64_t'/'uint32_t' types, requiring special conversion
operations to go between them. We've now dropped this distinction as
unnecessary, and the 'float*' types remain primarily for
documentation purposes when used in places like the function
prototypes of TCG helper functions.
This means that there's no need for a special gdb_get_float32()
function to write a float32 value to the GDB protocol buffer; we can
just use gdb_get_reg32().
Similarly, for reading a value out of the GDB buffer into a float32
we can use ldl_p() and need not use ldfl_p().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/sh4/gdbstub.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/sh4/gdbstub.c b/target/sh4/gdbstub.c
index 34ad3ca0508..3488f68e326 100644
--- a/target/sh4/gdbstub.c
+++ b/target/sh4/gdbstub.c
@@ -58,9 +58,9 @@ int superh_cpu_gdb_read_register(CPUState *cs, GByteArray
*mem_buf, int n)
return gdb_get_regl(mem_buf, env->fpscr);
case 25 ... 40:
if (env->fpscr & FPSCR_FR) {
- return gdb_get_float32(mem_buf, env->fregs[n - 9]);
+ return gdb_get_reg32(mem_buf, env->fregs[n - 9]);
}
- return gdb_get_float32(mem_buf, env->fregs[n - 25]);
+ return gdb_get_reg32(mem_buf, env->fregs[n - 25]);
case 41:
return gdb_get_regl(mem_buf, env->ssr);
case 42:
@@ -119,9 +119,9 @@ int superh_cpu_gdb_write_register(CPUState *cs, uint8_t
*mem_buf, int n)
break;
case 25 ... 40:
if (env->fpscr & FPSCR_FR) {
- env->fregs[n - 9] = ldfl_p(mem_buf);
+ env->fregs[n - 9] = ldl_p(mem_buf);
} else {
- env->fregs[n - 25] = ldfl_p(mem_buf);
+ env->fregs[n - 25] = ldl_p(mem_buf);
}
break;
case 41:
--
2.20.1
- [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code, Peter Maydell, 2021/02/08
- [PATCH 1/5] target/sh4: Drop use of gdb_get_float32() and ldfl_p(),
Peter Maydell <=
- [PATCH 2/5] target/m68k: Drop use of gdb_get_float64() and ldfq_p(), Peter Maydell, 2021/02/08
- [PATCH 4/5] gdbstub: Remove unused gdb_get_float32() and gdb_get_float64(), Peter Maydell, 2021/02/08
- [PATCH 3/5] target/ppc: Drop use of gdb_get_float64() and ldfq_p(), Peter Maydell, 2021/02/08
- [PATCH 5/5] bswap.h: Remove unused float-access functions, Peter Maydell, 2021/02/08
- Re: [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code, Philippe Mathieu-Daudé, 2021/02/08
- Re: [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code, Alex Bennée, 2021/02/09