[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] ppc/e500: Use start-powered-off CPUState property
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 4/9] ppc/e500: Use start-powered-off CPUState property |
Date: |
Wed, 22 Jul 2020 08:55:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/22/20 5:50 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
> the start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> ---
> hw/ppc/e500.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> NB: I was only able to test that this patch builds. I wasn't able to
> run it.
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index ab9884e315..dda71bc05d 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -704,9 +704,6 @@ static void ppce500_cpu_reset_sec(void *opaque)
>
> cpu_reset(cs);
>
> - /* Secondary CPU starts in halted state for now. Needs to change when
> - implementing non-kernel boot. */
> - cs->halted = 1;
> cs->exception_index = EXCP_HLT;
> }
>
> @@ -897,6 +894,13 @@ void ppce500_init(MachineState *machine)
> } else {
> /* Secondary CPUs */
> qemu_register_reset(ppce500_cpu_reset_sec, cpu);
> +
> + /*
> + * Secondary CPU starts in halted state for now. Needs to change
> + * when implementing non-kernel boot.
> + */
> + object_property_set_bool(OBJECT(cs), "start-powered-off", true,
> + &error_abort);
> }
> }
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH v2 1/9] target/arm: Move start-powered-off property to generic CPUState, (continued)
- [PATCH v2 2/9] target/arm: Move setting of CPU halted state to generic code, Thiago Jung Bauermann, 2020/07/21
- [PATCH v2 3/9] ppc/spapr: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/07/21
- [PATCH v2 4/9] ppc/e500: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/07/21
- [PATCH v2 5/9] mips/cps: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/07/21
- [PATCH v2 6/9] sparc/sun4m: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/07/21
- [RFC PATCH v2 7/9] sparc/sun4m: Don't set CPUState::halted in cpu_devinit(), Thiago Jung Bauermann, 2020/07/21