[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope
From: |
Alistair Francis |
Subject: |
Re: [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope |
Date: |
Mon, 6 Jul 2020 09:47:55 -0700 |
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> We only use these register definitions in files under the
> hw/usb/ directory. Keep that header local by moving it there.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> {include/hw => hw}/usb/dwc2-regs.h | 0
> hw/usb/hcd-dwc2.c | 2 +-
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename {include/hw => hw}/usb/dwc2-regs.h (100%)
>
> diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h
> similarity index 100%
> rename from include/hw/usb/dwc2-regs.h
> rename to hw/usb/dwc2-regs.h
> diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c
> index ccf05d0823..252b60ef65 100644
> --- a/hw/usb/hcd-dwc2.c
> +++ b/hw/usb/hcd-dwc2.c
> @@ -34,7 +34,6 @@
> #include "qemu/osdep.h"
> #include "qemu/units.h"
> #include "qapi/error.h"
> -#include "hw/usb/dwc2-regs.h"
> #include "hw/usb/hcd-dwc2.h"
> #include "hw/irq.h"
> #include "sysemu/dma.h"
> @@ -43,6 +42,7 @@
> #include "qemu/timer.h"
> #include "qemu/log.h"
> #include "hw/qdev-properties.h"
> +#include "dwc2-regs.h"
>
> #define USB_HZ_FS 12000000
> #define USB_HZ_HS 96000000
> --
> 2.21.3
>
>
- Re: [PATCH 04/26] hw/usb: Reduce 'exec/memory.h' inclusion, (continued)
- [PATCH 05/26] hw/usb/desc: Add missing header, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 06/26] hw/usb/hcd-dwc2: Remove unnecessary includes, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 07/26] hw/usb/hcd-dwc2: Restrict some headers to source, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 09/26] hw/usb/hcd-ehci: Remove unnecessary include, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 10/26] hw/usb/hcd-ehci: Move few definitions from header to source, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 11/26] hw/usb/hcd-xhci: Add missing header, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 12/26] hw/usb/hcd-musb: Restrict header scope, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 14/26] hw/usb/quirks: Rename included source with '.inc.c' suffix, Philippe Mathieu-Daudé, 2020/07/04