[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_si
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple() |
|
Date: |
Tue, 30 Jun 2020 11:48:43 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> We use "create_simple" names for functions that allocate, initialize,
> configure and realize device objects: pci_create_simple(),
> isa_create_simple(), usb_create_simple(). For consistency, rename
> i2c_create_slave() as i2c_slave_create_simple(). Since we have
> to update all the callers, also let it return a I2CSlave object.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- Re: [PATCH 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus(), (continued)
- [PATCH 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new(), Philippe Mathieu-Daudé, 2020/06/29
- [PATCH 3/5] hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref(), Philippe Mathieu-Daudé, 2020/06/29
- [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple(), Philippe Mathieu-Daudé, 2020/06/29
- [PATCH 5/5] hw/i2c: Document the I2C qdev helpers, Philippe Mathieu-Daudé, 2020/06/29
- Re: [PATCH 0/5] hw/i2c: Rename method names for consistency and add documentation, Corey Minyard, 2020/06/29