[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 14/18] guest memory protection: Rework the "memory-encryptio
From: |
David Gibson |
Subject: |
Re: [RFC v2 14/18] guest memory protection: Rework the "memory-encryption" property |
Date: |
Thu, 4 Jun 2020 15:56:38 +1000 |
On Mon, Jun 01, 2020 at 08:54:42PM -0700, Richard Henderson wrote:
> On 5/20/20 8:43 PM, David Gibson wrote:
> > +++ b/include/hw/boards.h
> > @@ -12,6 +12,8 @@
> > #include "qom/object.h"
> > #include "hw/core/cpu.h"
> >
> > +typedef struct GuestMemoryProtection GuestMemoryProtection;
> > +
>
> I think this needs to be in include/qemu/typedefs.h,
> and the other typedef in patch 10 needs to be moved there.
>
> IIRC, clang warns about duplicate typedefs.
Not, apparently, with the clang version I have, but I've made the
change anyway.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature