[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 13/18] guest memory protection: Move side effect out of mach
From: |
Richard Henderson |
Subject: |
Re: [RFC v2 13/18] guest memory protection: Move side effect out of machine_set_memory_encryption() |
Date: |
Mon, 1 Jun 2020 20:41:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 5/20/20 8:42 PM, David Gibson wrote:
> When the "memory-encryption" property is set, we also disable KSM
> merging for the guest, since it won't accomplish anything.
>
> We want that, but doing it in the property set function itself is
> thereoretically incorrect, in the unlikely event of some configuration
> environment that set the property then cleared it again before
> constructing the guest.
>
> But more important, it makes some other cleanups we want more
> difficult. So, instead move this logic to machine_run_board_init()
> conditional on the final value of the property.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/core/machine.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC v2 13/18] guest memory protection: Move side effect out of machine_set_memory_encryption(),
Richard Henderson <=