[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/15] hw/nvram/mac_nvram: Convert debug printf()s to trace events
From: |
David Gibson |
Subject: |
[PULL 13/15] hw/nvram/mac_nvram: Convert debug printf()s to trace events |
Date: |
Wed, 27 May 2020 15:38:07 +1000 |
From: Philippe Mathieu-Daudé <address@hidden>
Convert NVR_DPRINTF() to trace events and remove ifdef'ry.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/nvram/mac_nvram.c | 17 +++--------------
hw/nvram/trace-events | 4 ++++
2 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c
index ff5db03e6b..beec1c4e4d 100644
--- a/hw/nvram/mac_nvram.c
+++ b/hw/nvram/mac_nvram.c
@@ -30,18 +30,9 @@
#include "migration/vmstate.h"
#include "qemu/cutils.h"
#include "qemu/module.h"
+#include "trace.h"
#include <zlib.h>
-/* debug NVR */
-//#define DEBUG_NVR
-
-#ifdef DEBUG_NVR
-#define NVR_DPRINTF(fmt, ...) \
- do { printf("NVR: " fmt , ## __VA_ARGS__); } while (0)
-#else
-#define NVR_DPRINTF(fmt, ...)
-#endif
-
#define DEF_SYSTEM_SIZE 0xc10
/* macio style NVRAM device */
@@ -51,9 +42,8 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr,
MacIONVRAMState *s = opaque;
addr = (addr >> s->it_shift) & (s->size - 1);
+ trace_macio_nvram_write(addr, value);
s->data[addr] = value;
- NVR_DPRINTF("writeb addr %04" HWADDR_PRIx " val %" PRIx64 "\n",
- addr, value);
}
static uint64_t macio_nvram_readb(void *opaque, hwaddr addr,
@@ -64,8 +54,7 @@ static uint64_t macio_nvram_readb(void *opaque, hwaddr addr,
addr = (addr >> s->it_shift) & (s->size - 1);
value = s->data[addr];
- NVR_DPRINTF("readb addr %04" HWADDR_PRIx " val %" PRIx32 "\n",
- addr, value);
+ trace_macio_nvram_read(addr, value);
return value;
}
diff --git a/hw/nvram/trace-events b/hw/nvram/trace-events
index 0dea9260ce..e023193295 100644
--- a/hw/nvram/trace-events
+++ b/hw/nvram/trace-events
@@ -13,3 +13,7 @@ fw_cfg_add_string(uint16_t key_value, const char *key_name,
const char *value) "
fw_cfg_add_i16(uint16_t key_value, const char *key_name, uint16_t value) "key
0x%04" PRIx16 " '%s', value 0x%" PRIx16
fw_cfg_add_i32(uint16_t key_value, const char *key_name, uint32_t value) "key
0x%04" PRIx16 " '%s', value 0x%" PRIx32
fw_cfg_add_i64(uint16_t key_value, const char *key_name, uint64_t value) "key
0x%04" PRIx16 " '%s', value 0x%" PRIx64
+
+# mac_nvram.c
+macio_nvram_read(uint32_t addr, uint8_t val) "read addr=0x%04"PRIx32"
val=0x%02x"
+macio_nvram_write(uint32_t addr, uint8_t val) "write addr=0x%04"PRIx32"
val=0x%02x"
--
2.26.2
- [PULL 05/15] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2, (continued)
- [PULL 05/15] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2, David Gibson, 2020/05/27
- [PULL 02/15] ppc/spapr: add a POWER10 CPU model, David Gibson, 2020/05/27
- [PULL 10/15] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(), David Gibson, 2020/05/27
- [PULL 07/15] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), David Gibson, 2020/05/27
- [PULL 06/15] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), David Gibson, 2020/05/27
- [PULL 12/15] hw/pci-bridge/dec: Remove dead debug code, David Gibson, 2020/05/27
- [PULL 04/15] target/ppc: Add support for scv and rfscv instructions, David Gibson, 2020/05/27
- [PULL 09/15] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), David Gibson, 2020/05/27
- [PULL 11/15] target/ppc: Don't update radix PTE R/C bits with gdbstub, David Gibson, 2020/05/27
- [PULL 14/15] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again, David Gibson, 2020/05/27
- [PULL 13/15] hw/nvram/mac_nvram: Convert debug printf()s to trace events,
David Gibson <=
- [PULL 15/15] vfio/nvlink: Remove exec permission to avoid SELinux AVCs, David Gibson, 2020/05/27
- Re: [PULL 00/15] ppc-for-5.1 queue 20200527, no-reply, 2020/05/27
- Re: [PULL 00/15] ppc-for-5.1 queue 20200527, Peter Maydell, 2020/05/28