[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs
From: |
David Gibson |
Subject: |
Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs |
Date: |
Mon, 25 May 2020 15:06:07 +1000 |
On Fri, May 22, 2020 at 03:08:56PM -0500, Reza Arbab wrote:
> On Fri, May 22, 2020 at 02:53:33PM -0500, Reza Arbab wrote:
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -889,10 +889,16 @@ static int spapr_dt_rng(void *fdt)
> > static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt)
> > {
> > MachineState *ms = MACHINE(spapr);
> > + SpaprMachineClass *smc = SPAPR_MACHINE_GET_CLASS(ms);
> > int rtas;
> > GString *hypertas = g_string_sized_new(256);
> > GString *qemu_hypertas = g_string_sized_new(256);
> > - uint32_t refpoints[] = { cpu_to_be32(0x4), cpu_to_be32(0x4) };
> > + uint32_t refpoints[] = {
> > + cpu_to_be32(0x4),
> > + cpu_to_be32(0x4),
> > + cpu_to_be32(0x2),
> > + };
> > + uint32_t nr_refpoints = 3;
>
> Gah, I soon as I hit send I realize this should be
>
> uint32_t nr_refpoints = ARRAY_SIZE(refpoints);
>
> Can you fixup or should I send a v4?
I had one other comment that needs addressing, so you might as well
send a v4.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature