Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

[Dennis Clarke]

On 2020-04-21 03:17, Philippe Mathieu-Daudé wrote:
> On 4/21/20 12:53 AM, Dennis Clarke wrote:
> > On 4/20/20 6:56 PM, Peter Maydell wrote:
> > > On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé <address@hidden>
> > > wrote:
> > > > This fixes:
> > > >
> > > >     $ qemu-system-ppc64 \
> > > >     -machine pseries-4.1 -cpu power9 \
> > > >     -smp 4 -m 12G -accel tcg ...
> > > >     ...
> > > >     Quiescing Open Firmware ...
> > > >     Booting Linux via __start() @ 0x0000000002000000 ...
> > > >     Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
> > > >     Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
> > > >     Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
> > > >
> > > > [*] https://www.mail-archive.com/address@hidden/msg05400.html
> > > >
> > > > Fixes: 0418bf78fe8 ("Fix ISA v3.0 (POWER9) slbia implementation")
> > > > Reported-by: Dennis Clarke <address@hidden>
> > > > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > >
> > > I propose to apply this patch for 5.0 rc4 (as well as the
> > > ppc pullreq already sent), since the iscsi bugfix means
> > > we need an rc4 anyway. Any objections?
> >
> > I have been running rc3 with this patch fine for some days now.  Both
> > with and without a debug enabled build wherein the performance
> > difference between the two is obvious.
>
> Thanks for testing it! Can we use your:
>
> Tested-by: Dennis Clarke <address@hidden>
>
> tag?


Of course.  Even "running fine by that old UNIX guy" if you want.


--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional