[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v18 1/7] Wrapper function to wait on condition for the main l
From: |
Greg Kurz |
Subject: |
Re: [PATCH v18 1/7] Wrapper function to wait on condition for the main loop mutex |
Date: |
Sun, 5 Jan 2020 16:17:08 +0100 |
On Thu, 2 Jan 2020 13:21:05 +0530
Ganesh Goudar <address@hidden> wrote:
> From: Aravinda Prasad <address@hidden>
>
> Introduce a wrapper function to wait on condition for
> the main loop mutex. This function atomically releases
> the main loop mutex and causes the calling thread to
> block on the condition. This wrapper is required because
> qemu_global_mutex is a static variable.
>
> Signed-off-by: Aravinda Prasad <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> ---
This should have your Signed-off-by: tag as well.
> cpus.c | 5 +++++
> include/qemu/main-loop.h | 8 ++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/cpus.c b/cpus.c
> index b472378b70..79388d2b0f 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1835,6 +1835,11 @@ void qemu_mutex_unlock_iothread(void)
> qemu_mutex_unlock(&qemu_global_mutex);
> }
>
> +void qemu_cond_wait_iothread(QemuCond *cond)
> +{
> + qemu_cond_wait(cond, &qemu_global_mutex);
> +}
> +
> static bool all_vcpus_paused(void)
> {
> CPUState *cpu;
> diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h
> index f6ba78ea73..a6d20b0719 100644
> --- a/include/qemu/main-loop.h
> +++ b/include/qemu/main-loop.h
> @@ -295,6 +295,14 @@ void qemu_mutex_lock_iothread_impl(const char *file, int
> line);
> */
> void qemu_mutex_unlock_iothread(void);
>
> +/*
> + * qemu_cond_wait_iothread: Wait on condition for the main loop mutex
> + *
> + * This function atomically releases the main loop mutex and causes
> + * the calling thread to block on the condition.
> + */
> +void qemu_cond_wait_iothread(QemuCond *cond);
> +
> /* internal interfaces */
>
> void qemu_fd_register(int fd);
- [PATCH v18 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKM guests, Ganesh Goudar, 2020/01/02
- [PATCH v18 1/7] Wrapper function to wait on condition for the main loop mutex, Ganesh Goudar, 2020/01/02
- Re: [PATCH v18 1/7] Wrapper function to wait on condition for the main loop mutex,
Greg Kurz <=
- [PATCH v18 2/7] ppc: spapr: Introduce FWNMI capability, Ganesh Goudar, 2020/01/02
- [PATCH v18 3/7] target/ppc: Handle NMI guest exit, Ganesh Goudar, 2020/01/02
- [PATCH v18 4/7] target/ppc: Build rtas error log upon an MCE, Ganesh Goudar, 2020/01/02
- [PATCH v18 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls, Ganesh Goudar, 2020/01/02