qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type
Date: Tue, 12 Nov 2019 19:15:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/11/19 10:49 PM, Cleber Rosa wrote:
On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote:
@@ -310,7 +302,7 @@ class BootLinuxConsole(Test):
       def test_arm_emcraft_sf2(self):
           """
           :avocado: tags=arch:arm
-        :avocado: tags=machine:emcraft_sf2
+        :avocado: tags=machine:emcraft-sf2

Maybe add a comment about this change, "Since avocado 72(?) we can ... so
use ..."


You mean on this specific test docstring?  I'm confused if there's a

No! Just in the commit description :)

special reason for doing it here, of if you're suggesting adding a
similar command to all tag entries which make use of the extended
character set (which I think would be too verbose, repetitve, and hard
to maintain).

diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
index af47d2795a..293dccb89a 100644
--- a/tests/acceptance/cpu_queries.py
+++ b/tests/acceptance/cpu_queries.py
@@ -20,8 +20,8 @@ class QueryCPUModelExpansion(Test):
       def test(self):
           """
           :avocado: tags=arch:x86_64
+        :avocado: tags=machine:none

Not to confuse with None :)


Yep! :)

- Cleber.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]