[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory h
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner |
|
Date: |
Mon, 21 Oct 2019 10:41:09 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote:
> All the memory_region_allocate_system_memory() pass a MachineState
> argument. Add an assertion to ensure the new boards/machines added
> set this argument, so all system memory object have the machine as
> its QOM owner.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/core/numa.c | 4 +---
> include/hw/boards.h | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
It would be a good idea to add __attribute__((nonnull(x,y,z))) as well, but
since we don't currently have any markup for that in qemu, that can go in a
separate patch set.
r~
- Re: [PATCH 18/21] hw/mips: Let the machine be the owner of the system memory, (continued)
Re: [EXTERNAL][PATCH 18/21] hw/mips: Let the machine be the owner of the system memory, Aleksandar Markovic, 2019/10/21
[PATCH 19/21] hw/ppc: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/20
[PATCH 20/21] hw/sparc: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/20
[PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner, Philippe Mathieu-Daudé, 2019/10/20
Re: [PATCH 00/21] hw: Let the machine be the owner of the system memory, no-reply, 2019/10/20
Re: [PATCH 00/21] hw: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/21