Re: [PATCH 5/7] target/ppc: change struct PPC_DFP decimal storage from uint64[2] to ppc_vsr_t

[Richard Henderson]

On 9/24/19 8:35 AM, Mark Cave-Ayland wrote:
> There are several places in dfp_helper.c that access the decimal number
> representations in struct PPC_DFP via HI_IDX and LO_IDX defines which are set
> at the top of dfp_helper.c according to the host endian.
> 
> However we can instead switch to using ppc_vsr_t for decimal numbers and then
> make subsequent use of the existing VsrD() macros to access the correct
> element regardless of host endian. Note that 64-bit decimals are stored in the
> LSB of ppc_vsr_t (equivalent to VsrD(1)).
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/dfp_helper.c | 210 +++++++++++++++++++++-------------------
>  1 file changed, 108 insertions(+), 102 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~