qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion


From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness
Date: Wed, 7 Aug 2019 12:27:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 07/08/19 10:33, address@hidden wrote:
> +#ifdef NEED_CPU_H
> +    return ctz32(size) | MO_TE;
> +#else
>      return ctz32(size);
> +#endif

Please use two separate functions for this, for example size_to_memop
and target_size_to_memop, or even just add MO_TE to the callers that
need it (only cputlb.c?).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]