[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM inter
From: |
Christophe de Dinechin |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface |
Date: |
Wed, 31 Jul 2019 12:17:50 +0200 |
User-agent: |
mu4e 1.3.2; emacs 26.2 |
Peter Maydell writes:
> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck <address@hidden> wrote:
>>
>> On Tue, 30 Jul 2019 14:44:21 +0100
>> Peter Maydell <address@hidden> wrote:
>>
>> > On Tue, 30 Jul 2019 at 14:42, Cornelia Huck <address@hidden> wrote:
>> > > I'm having a hard time figuring out what a 'cold' or a 'warm' reset is
>> > > supposed to be... can you add a definition/guideline somewhere?
>> >
>> > Generally "cold" reset is "power on" and "warm" is "we were already
>> > powered-on, but somebody flipped a reset line somewhere".
>>
>> Ok, that makes sense... my main concern is to distinguish that in a
>> generic way, as it is a generic interface. What about adding something
>> like:
>>
>> "A 'cold' reset means that the object to be reset is initially reset; a
>> 'warm'
>> reset means that the object to be reset has already been initialized."
>>
>> Or is that again too generic?
>
> I think it doesn't quite capture the idea -- an object can have already
> been reset and then get a 'cold' reset: this is like having a powered-on
> machine and then power-cycling it.
>
> The 'warm' reset is the vaguer one, because the specific behaviour
> is somewhat device-dependent (many devices might not have any
> difference from 'cold' reset, for those that do the exact detail
> of what doesn't get reset on warm-reset will vary). But every
> device should have some kind of "as if you power-cycled it" (or
> for QEMU, "go back to the same state as if you just started QEMU on the
> command line"). Our current "reset" method is really cold-reset.
Is there any concept of locality associated with warm reset?
For example, you'd expect a cold reset to happen on the whole system,
but I guess a warm reset could be restricted to a single bus.
The documentation should give examples of how warm reset could be
triggered, and what it could do differently from cold reset.
>
> thanks
> -- PMM
--
Cheers,
Christophe de Dinechin (IRC c3d)
- Re: [Qemu-ppc] [PATCH v3 06/33] add the vmstate description for device reset state, (continued)
- [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Damien Hedde, 2019/07/29
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Cornelia Huck, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Peter Maydell, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Cornelia Huck, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Peter Maydell, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Damien Hedde, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, Cornelia Huck, 2019/07/30
- Re: [Qemu-ppc] [PATCH v3 01/33] Create Resettable QOM interface, David Gibson, 2019/07/31
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface,
Christophe de Dinechin <=
[Qemu-ppc] [PATCH v3 05/33] Switch to new api in qdev/bus, Damien Hedde, 2019/07/29
[Qemu-ppc] [PATCH v3 10/33] vl.c: remove qbus_reset_all registration, Damien Hedde, 2019/07/29
[Qemu-ppc] [PATCH v3 03/33] Replace all call to device_reset by call to device_legacy_reset, Damien Hedde, 2019/07/29
[Qemu-ppc] [PATCH v3 12/33] hw/pci/: remove qdev/qbus_reset_all call, Damien Hedde, 2019/07/29
[Qemu-ppc] [PATCH v3 18/33] hw/audio/intel-hda.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
[Qemu-ppc] [PATCH v3 16/33] hw/input/adb.c: remove qdev_reset_all call, Damien Hedde, 2019/07/29