qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_P


From: BALATON Zoltan
Subject: Re: [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
Date: Mon, 15 Jul 2019 13:10:19 +0200 (CEST)
User-agent: Alpine 2.21.9999 (BSF 287 2018-06-16)

On Mon, 15 Jul 2019, Thomas Huth wrote:
On 15/07/2019 12.54, BALATON Zoltan wrote:
On Mon, 15 Jul 2019, Philippe Mathieu-Daudé wrote:
The USB_EHCI entry currently include PCI code. Since the EHCI
implementation is already split in sysbus/PCI, add a new
USB_EHCI_PCI. There are no logical changes, but the Kconfig
dependencies tree is cleaner.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/usb/Kconfig?????? | 9 ++++++---
hw/usb/Makefile.objs | 5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 564305e283..495c6f2d48 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -19,13 +19,16 @@ config USB_OHCI_PCI

config USB_EHCI
??? bool
-??? default y if PCI_DEVICES
-??? depends on PCI
??? select USB

+config USB_EHCI_PCI
+??? bool
+??? default y if PCI_DEVICES
+??? select USB_EHCI
+
config USB_EHCI_SYSBUS
??? bool
-??? select USB
+??? select USB_EHCI

Isn't this making USB_EHCI effectively the same as USB so maybe you
don't need to keep that around any more. Can you just add select USB to
USB_EHCI_PCI and USB_EHCI_SYSBUS and delete USB_EHCI?

If you want to compile without USB_EHCI_PCI and without USB_EHCI_SYSBUS,
but with USB (e.g. due to XHCI), I think we should not include
hcd-ehci.o file in the build. So I think it's fine that we have a
separate config switch for this file.

So shouldn't build depend on either USB_EHCI_PCI or USB_EHCI_SYSBUS selected then?

Regards,
BALATON Zoltan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]