[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 01/15] target/ppc: remove getVSR()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c |
Date: |
Wed, 12 Jun 2019 12:45:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> void helper_xvxsigsp(CPUPPCState *env, uint32_t opcode)
> {
> - ppc_vsr_t xt, xb;
> + ppc_vsr_t *xt = &env->vsr[xT(opcode)];
> + ppc_vsr_t *xb = &env->vsr[xB(opcode)];
> + ppc_vsr_t t = *xt;
> uint32_t exp, i, fraction;
>
> - getVSR(xB(opcode), &xb, env);
> - memset(&xt, 0, sizeof(xt));
Change in behaviour -- zero init to copy init.
Note for future cleanup: most of these initializations do not need to happen,
because we overwrite all elements of T without consuming the previous value.
> @@ -3410,23 +3382,22 @@ void helper_xsrqpi(CPUPPCState *env, uint32_t opcode)
> env->fp_status.float_exception_flags &= ~float_flag_inexact;
> }
>
> - helper_compute_fprf_float128(env, xt.f128);
> + helper_compute_fprf_float128(env, t.f128);
> + *xt = t;
> do_float_check_status(env, GETPC());
> - putVSR(rD(opcode) + 32, &xt, env);
Change in behaviour -- writeback happens before do_float_check_status instead
of after. This may well be a bug fix, but if so should happen separately.
r~
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c, (continued)
- [Qemu-ppc] [PATCH v2 09/15] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 08/15] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 05/15] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 07/15] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c,
Richard Henderson <=
- [Qemu-ppc] [PATCH v2 13/15] target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 10/15] target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 11/15] target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 14/15] target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 12/15] target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
- [Qemu-ppc] [PATCH v2 15/15] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro, Mark Cave-Ayland, 2019/06/02