[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 12/44] target/ppc: Fix vsum2sws
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 12/44] target/ppc: Fix vsum2sws |
Date: |
Wed, 29 May 2019 16:49:45 +1000 |
From: Anton Blanchard <address@hidden>
A recent cleanup changed the pre zeroing of the result from 64 bit
to 32 bit operations:
- result.u64[i] = 0;
+ result.VsrW(i) = 0;
This corrupts the result.
Fixes: 60594fea298d ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in
int_helper.c")
Signed-off-by: Anton Blanchard <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target/ppc/int_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
index 2bad2d5620..093ef74b59 100644
--- a/target/ppc/int_helper.c
+++ b/target/ppc/int_helper.c
@@ -2053,7 +2053,7 @@ void helper_vsum2sws(CPUPPCState *env, ppc_avr_t *r,
ppc_avr_t *a, ppc_avr_t *b)
for (i = 0; i < ARRAY_SIZE(r->u64); i++) {
int64_t t = (int64_t)b->VsrSW(upper + i * 2);
- result.VsrW(i) = 0;
+ result.VsrD(i) = 0;
for (j = 0; j < ARRAY_SIZE(r->u64); j++) {
t += a->VsrSW(2 * i + j);
}
--
2.21.0
- [Qemu-ppc] [PULL 02/44] configure: Distinguish ppc64 and ppc64le hosts, (continued)
- [Qemu-ppc] [PULL 02/44] configure: Distinguish ppc64 and ppc64le hosts, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 05/44] hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 08/44] target/ppc: Add ibm, purr and ibm, spurr device-tree properties, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 04/44] target/ppc/kvm: Fix trace typo, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 10/44] target/ppc: Fix xxbrq, xxbrw, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 14/44] spapr/xive: EQ page should be naturally aligned, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 13/44] target/ppc: Fix xxspltib, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 15/44] spapr/xive: fix EQ page addresses above 64GB, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 07/44] hw/ppc/40p: use 1900 as a base year, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 06/44] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 12/44] target/ppc: Fix vsum2sws,
David Gibson <=
- [Qemu-ppc] [PULL 09/44] target/ppc: Fix xvxsigdp, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 11/44] target/ppc: Fix vslv and vsrv, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 16/44] spapr/xive: print out the EQ page address in the monitor, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 26/44] spapr/xive: add KVM support, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 17/44] Fix typo on "info pic" monitor cmd output for xive, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 24/44] spapr: Fix phb_placement backwards compatibility, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 20/44] spapr/xive: Sanity checks of OV5 during CAS, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 28/44] spapr/xive: add state synchronization with KVM, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 18/44] target/ppc: Optimise VSX_LOAD_SCALAR_DS and VSX_VECTOR_LOAD_STORE, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 25/44] spapr: Print out extra hints when CAS negotiation of interrupt mode fails, David Gibson, 2019/05/29