Re: [Qemu-ppc] [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190521

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190521
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e5ddc97218 spapr/irq: add KVM support to the 'dual' machine
fca452577f ppc/xics: fix irq priority in ics_set_irq_type()
29b7a81d1e spapr/irq: initialize the IRQ device only once
87a4da5510 spapr/irq: introduce a spapr_irq_init_device() helper
0383f8423f spapr: check for the activation of the KVM IRQ device
18180201f2 spapr: introduce routines to delete the KVM IRQ device
19da42249f sysbus: add a sysbus_mmio_unmap() helper
b7d5522841 spapr/xive: activate KVM support
ea75c02b98 spapr/xive: add migration support for KVM
9ddbedfd4a spapr/xive: introduce a VM state change handler
983f6ce774 spapr/xive: add state synchronization with KVM
4c58e1c365 spapr/xive: add hcall support when under KVM
ed972a8a73 spapr/xive: add KVM support
60228c8254 linux-headers: Update linux headers to 5.2-rc1
ff4f5b42ce spapr: Print out extra hints when CAS negotiation of interrupt mode 
fails
20694916c6 spapr: Fix phb_placement backwards compatibility
3d88dfec8b target/ppc: Use vector variable shifts for VSL, VSR, VSRA
c581233e63 spapr: Add forgotten capability to migration stream
d6eed8bc5a target/ppc: Set PSSCR_EC on cpu halt to prevent spurious wakeup
68103a591e spapr/xive: Sanity checks of OV5 during CAS
9969976fda target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p
e209b74962 target/ppc: Optimise VSX_LOAD_SCALAR_DS and VSX_VECTOR_LOAD_STORE
83b772160a Fix typo on "info pic" monitor cmd output for xive
19629f700a spapr/xive: print out the EQ page address in the monitor
4d7a578215 spapr/xive: fix EQ page addresses above 64GB
03d365a3c2 spapr/xive: EQ page should be naturally aligned
bef2fb80d6 target/ppc: Fix xxspltib
c89cc9d810 target/ppc: Fix vsum2sws
136f68b7ff target/ppc: Fix vslv and vsrv
297a17ee6e target/ppc: Fix xxbrq, xxbrw
26b66a8d9f target/ppc: Fix xvxsigdp
23b86445a0 target/ppc: Add ibm, purr and ibm, spurr device-tree properties
90db445a15 hw/ppc/40p: use 1900 as a base year
d66f37cd84 hw/ppc/40p: Move the MC146818 RTC to the board where it belongs
436f01639e hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string
d61292db61 configure: Use quotes around uses of $CPU_CFLAGS
7ef044de39 configure: Distinguish ppc64 and ppc64le hosts
54d89e97a7 target/ppc/kvm: Fix trace typo

=== OUTPUT BEGIN ===
1/38 Checking commit 54d89e97a700 (target/ppc/kvm: Fix trace typo)
2/38 Checking commit 7ef044de39da (configure: Distinguish ppc64 and ppc64le 
hosts)
3/38 Checking commit d61292db61ad (configure: Use quotes around uses of 
$CPU_CFLAGS)
4/38 Checking commit 436f01639ec2 (hw/ppc/prep: use TYPE_MC146818_RTC instead 
of a hardcoded string)
5/38 Checking commit d66f37cd8453 (hw/ppc/40p: Move the MC146818 RTC to the 
board where it belongs)
6/38 Checking commit 90db445a152f (hw/ppc/40p: use 1900 as a base year)
7/38 Checking commit 23b86445a074 (target/ppc: Add ibm, purr and ibm, spurr 
device-tree properties)
8/38 Checking commit 26b66a8d9f7e (target/ppc: Fix xvxsigdp)
9/38 Checking commit 297a17ee6e26 (target/ppc: Fix xxbrq, xxbrw)
10/38 Checking commit 136f68b7ff5a (target/ppc: Fix vslv and vsrv)
11/38 Checking commit c89cc9d810ce (target/ppc: Fix vsum2sws)
12/38 Checking commit bef2fb80d616 (target/ppc: Fix xxspltib)
13/38 Checking commit 03d365a3c2b7 (spapr/xive: EQ page should be naturally 
aligned)
14/38 Checking commit 4d7a57821551 (spapr/xive: fix EQ page addresses above 
64GB)
15/38 Checking commit 19629f700a46 (spapr/xive: print out the EQ page address 
in the monitor)
16/38 Checking commit 83b772160a74 (Fix typo on "info pic" monitor cmd output 
for xive)
17/38 Checking commit e209b7496243 (target/ppc: Optimise VSX_LOAD_SCALAR_DS and 
VSX_VECTOR_LOAD_STORE)
18/38 Checking commit 9969976fdaf0 (target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, 
xvneg[sd]p, xvcpsgn[sd]p)
19/38 Checking commit 68103a591eed (spapr/xive: Sanity checks of OV5 during CAS)
20/38 Checking commit d6eed8bc5a93 (target/ppc: Set PSSCR_EC on cpu halt to 
prevent spurious wakeup)
21/38 Checking commit c581233e6382 (spapr: Add forgotten capability to 
migration stream)
22/38 Checking commit 3d88dfec8bce (target/ppc: Use vector variable shifts for 
VSL, VSR, VSRA)
23/38 Checking commit 20694916c6fa (spapr: Fix phb_placement backwards 
compatibility)
24/38 Checking commit ff4f5b42ced8 (spapr: Print out extra hints when CAS 
negotiation of interrupt mode fails)
ERROR: line over 90 characters
#27: FILE: hw/ppc/spapr_hcall.c:1649:
+            error_report("Guest requested unavailable interrupt mode (XIVE), 
try the ic-mode=xive or ic-mode=dual machine property");

ERROR: line over 90 characters
#33: FILE: hw/ppc/spapr_hcall.c:1654:
+            error_report("Guest requested unavailable interrupt mode (XICS), 
either don't set the ic-mode machine property or try ic-mode=xics or 
ic-mode=dual");

total: 2 errors, 0 warnings, 14 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

25/38 Checking commit 60228c825479 (linux-headers: Update linux headers to 
5.2-rc1)
26/38 Checking commit ed972a8a731f (spapr/xive: add KVM support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#130: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 26/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/38 Checking commit 4c58e1c3658d (spapr/xive: add hcall support when under 
KVM)
28/38 Checking commit 983f6ce774a0 (spapr/xive: add state synchronization with 
KVM)
29/38 Checking commit 9ddbedfd4a2d (spapr/xive: introduce a VM state change 
handler)
30/38 Checking commit ea75c02b9831 (spapr/xive: add migration support for KVM)
31/38 Checking commit b7d5522841de (spapr/xive: activate KVM support)
32/38 Checking commit 19da42249f6d (sysbus: add a sysbus_mmio_unmap() helper)
33/38 Checking commit 18180201f29a (spapr: introduce routines to delete the KVM 
IRQ device)
34/38 Checking commit 0383f8423fef (spapr: check for the activation of the KVM 
IRQ device)
35/38 Checking commit 87a4da5510ee (spapr/irq: introduce a 
spapr_irq_init_device() helper)
36/38 Checking commit 29b7a81d1e2a (spapr/irq: initialize the IRQ device only 
once)
37/38 Checking commit fca452577f35 (ppc/xics: fix irq priority in 
ics_set_irq_type())
38/38 Checking commit e5ddc9721811 (spapr/irq: add KVM support to the 'dual' 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden