[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 8/9] target/ppc: Fix dtstsfi and dtstsfiq
From: |
Anton Blanchard |
Subject: |
[Qemu-ppc] [PATCH 8/9] target/ppc: Fix dtstsfi and dtstsfiq |
Date: |
Tue, 7 May 2019 10:48:10 +1000 |
The immediate field is 6 bits, not 5.
Fixes: 217f6b88058f ("target-ppc: add dtstsfi[q] instructions")
Signed-off-by: Anton Blanchard <address@hidden>
---
target/ppc/internal.h | 2 ++
target/ppc/translate/dfp-impl.inc.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/ppc/internal.h b/target/ppc/internal.h
index fb6f64ed1e..4719369cc5 100644
--- a/target/ppc/internal.h
+++ b/target/ppc/internal.h
@@ -123,6 +123,8 @@ static inline uint32_t SPR(uint32_t opcode)
EXTRACT_SHELPER(SIMM, 0, 16);
/* 16 bits unsigned immediate value */
EXTRACT_HELPER(UIMM, 0, 16);
+/* 6 bits unsigned immediate value */
+EXTRACT_HELPER(UIMM6, 16, 6);
/* 5 bits signed immediate value */
EXTRACT_SHELPER(SIMM5, 16, 5);
/* 5 bits signed immediate value */
diff --git a/target/ppc/translate/dfp-impl.inc.c
b/target/ppc/translate/dfp-impl.inc.c
index 6c556dc2e1..5b01c9239d 100644
--- a/target/ppc/translate/dfp-impl.inc.c
+++ b/target/ppc/translate/dfp-impl.inc.c
@@ -55,7 +55,7 @@ static void gen_##name(DisasContext *ctx) \
return; \
} \
gen_update_nip(ctx, ctx->base.pc_next - 4); \
- uim = tcg_const_i32(UIMM5(ctx->opcode)); \
+ uim = tcg_const_i32(UIMM6(ctx->opcode)); \
rb = gen_fprp_ptr(rB(ctx->opcode)); \
gen_helper_##name(cpu_crf[crfD(ctx->opcode)], \
cpu_env, uim, rb); \
--
2.20.1
- [Qemu-ppc] [PATCH 6/9] target/ppc: Fix vslv and vsrv, (continued)
- [Qemu-ppc] [PATCH 6/9] target/ppc: Fix vslv and vsrv, Anton Blanchard, 2019/05/06
- [Qemu-ppc] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/06
- Re: [Qemu-ppc] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/07
- [Qemu-ppc] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Mark Cave-Ayland, 2019/05/10
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Mark Cave-Ayland, 2019/05/07
[Qemu-ppc] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm, Anton Blanchard, 2019/05/06
[Qemu-ppc] [PATCH 8/9] target/ppc: Fix dtstsfi and dtstsfiq,
Anton Blanchard <=
[Qemu-ppc] [PATCH 9/9] target/ppc: Fix vsum2sws, Anton Blanchard, 2019/05/06
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Alexey Kardashevskiy, 2019/05/06
Re: [Qemu-ppc] [PATCH 1/9] target/ppc: Fix xvxsigdp, David Gibson, 2019/05/07
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Philippe Mathieu-Daudé, 2019/05/07
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Eric Blake, 2019/05/07