[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] configure: Use quotes around use
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS
Thu, 2 May 2019 01:49:19 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
On 5/1/19 5:38 PM, Richard Henderson wrote:
> About half of the values to which CPU_CFLAGS is set
> have multiple space separated arguments.
> Signed-off-by: Richard Henderson <address@hidden>
> configure | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
> diff --git a/configure b/configure
> index 234cb929ca..16bd4375d1 100755
> --- a/configure
> +++ b/configure
> @@ -1543,37 +1543,37 @@ case "$cpu" in
> LDFLAGS="-m64 $LDFLAGS"
> - cross_cc_cflags_ppc64=$CPU_CFLAGS
> + cross_cc_cflags_ppc64="$CPU_CFLAGS"
Makes no difference semantically (bare variable assignments are not
subject to word splitting or globbing, so the quotes don't change the
result); the only reason to change this is for consistency (using quotes
everywhere is easier to remember, whether or not they are in a context
So I'm okay whether this patch goes in or is omitted.
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org