Re: [Qemu-ppc] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

[David Gibson]

On Mon, Mar 25, 2019 at 01:06:08PM +0530, Aravinda Prasad wrote:
> 
> 
> On Monday 25 March 2019 11:47 AM, David Gibson wrote:
> > On Fri, Mar 22, 2019 at 12:03:49PM +0530, Aravinda Prasad wrote:
> >> Introduce a wrapper function to wait on condition for
> >> the main loop mutex. This function atomically releases
> >> the main loop mutex and causes the calling thread to
> >> block on the condition.
> >>
> >> Signed-off-by: Aravinda Prasad <address@hidden>
> > 
> > I don't see much value to this.  It's not really more expressive, and
> > is barely shorted than just open coding
> >     qemu_cond_wait(cond, &qemu_global_mutex)
> > wherever you need it.
> 
> I have done this way because qemu_global_mutex is static. Do you prefer
> removing static instead of this wrapper?

Ah, right.

I think keep the wrapper, then, but update the commit message to
include this rationale for it.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature